Update fixtures #26
Merged
Update fixtures #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe GPS coordinates in two JSON fixture files, Changes
Estimated code review effort1 (~2 minutes) Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
fixtures/ap-ptp.json(1 hunks)fixtures/sta-ptp.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Process test complexity
- GitHub Check: Build and publish Python 🐍 distributions 📦 to TestPyPI
🔇 Additional comments (1)
fixtures/sta-ptp.json (1)
1-1: Remote & local GPS coordinates are identical – likely unintendedBoth the top-level
"gps"block (lat: 53.379894) and the remote STA entry under"wireless"→"sta"[0]→"remote"→"gps"now share exactly the same coordinates.
In a PTP link the local and the remote radios should sit at different sites; test logic that relies on non-zero distance (e.g. link-budget, map display, Haversine calculations) will silently misbehave.Please double-check whether the remote latitude/longitude were meant to differ, and adjust one of the two blocks if necessary.
fixtures/ap-ptp.json
Outdated
| @@ -1 +1 @@ | |||
| {"chain_names":[{"number":1,"name": "Chain 0"},{"number":2,"name": "Chain 1"}],"host":{"hostname": "NanoStation 5AC ap name ","device_id": "03aa0d0b40fed0a47088293584ef5432","uptime":264888,"power_time":268683,"time": "2025-06-23 23:06:42","timestamp":2668313184,"fwversion": "v8.7.17","devmodel": "NanoStation 5AC loco","netrole": "bridge","loadavg":0.412598,"totalram":63447040,"freeram":16564224,"temperature":0,"cpuload":10.101010,"height":3},"genuine": "/images/genuine.png","services":{"dhcpc":false,"dhcpd":false,"dhcp6d_stateful":false,"pppoe":false,"airview":2},"firewall":{"iptables":false,"ebtables":false,"ip6tables":false,"eb6tables":false},"portfw":false,"wireless":{"essid": "DemoSSID","mode": "ap-ptp","ieeemode": "11ACVHT80","band":2,"compat_11n":0,"hide_essid":0,"apmac":"01:23:45:67:89:AB","antenna_gain":13,"frequency":5500,"center1_freq":5530,"dfs":1,"distance":0,"security": "WPA2","noisef":-89,"txpower":-3,"aprepeater":false,"rstatus":5,"chanbw":80,"rx_chainmask":3,"tx_chainmask":3,"nol_state":0,"nol_timeout":0,"cac_state":0,"cac_timeout":0,"rx_idx":8,"rx_nss":2,"tx_idx":9,"tx_nss":2,"throughput":{"tx":222,"rx":9907},"service":{"time":267181,"link":266003},"polling":{"cb_capacity":593970,"dl_capacity":647400,"ul_capacity":540540,"use":48,"tx_use":6,"rx_use":42,"atpc_status":2,"fixed_frame":false,"gps_sync":false,"ff_cap_rep":false},"count":1,"sta":[{"mac":"01:23:45:67:89:AB","lastip":"192.168.1.2","signal":-59,"rssi":37,"noisefloor":-89,"chainrssi":[35,32,0],"tx_idx":9,"rx_idx":8,"tx_nss":2,"rx_nss":2,"tx_latency":0,"distance":1,"tx_packets":0,"tx_lretries":0,"tx_sretries":0,"uptime":170281,"dl_signal_expect":-80,"ul_signal_expect":-55,"cb_capacity_expect":416000,"dl_capacity_expect":208000,"ul_capacity_expect":624000,"dl_rate_expect":3,"ul_rate_expect":8,"dl_linkscore":100,"ul_linkscore":86,"dl_avg_linkscore":100,"ul_avg_linkscore":88,"tx_ratedata":[175,4,47,200,673,158,163,138,68895,19577430],"stats":{"rx_bytes":206938324814,"rx_packets":149767200,"rx_pps":846,"tx_bytes":5265602739,"tx_packets":52980390,"tx_pps":0},"airmax":{"actual_priority":0,"beam":0,"desired_priority":0,"cb_capacity":593970,"dl_capacity":647400,"ul_capacity":540540,"atpc_status":2,"rx":{"usage":42,"cinr":31,"evm":[[31,28,33,32,32,32,31,31,31,29,30,32,30,27,34,31,31,30,32,29,31,29,31,33,31,31,32,30,31,34,33,31,30,31,30,31,31,32,31,30,33,31,30,31,27,31,30,30,30,30,30,29,32,34,31,30,28,30,29,35,31,33,32,29],[34,34,35,34,35,35,34,34,34,34,34,34,34,34,35,35,34,34,35,34,33,33,35,34,34,35,34,35,34,34,35,34,34,33,34,34,34,34,34,35,35,35,34,35,33,34,34,34,34,35,35,34,34,34,34,34,34,34,34,34,34,34,35,35]]},"tx":{"usage":6,"cinr":31,"evm":[[32,34,28,33,35,30,31,33,30,30,32,30,29,33,31,29,33,31,31,30,33,34,33,31,33,32,32,31,29,31,30,32,31,30,29,32,31,32,31,31,32,29,31,29,30,32,32,31,32,32,33,31,28,29,31,31,33,32,33,32,32,32,31,33],[37,37,37,38,38,37,36,38,38,37,37,37,37,37,39,37,37,37,37,37,37,36,37,37,37,37,37,37,37,38,37,37,38,37,37,37,38,37,38,37,37,37,37,37,36,37,37,37,37,37,37,38,37,37,38,37,36,37,37,37,37,37,37,37]]}},"last_disc":1,"remote":{"age":1,"device_id": "d4f4cdf82961e619328a8f72f8d7653b","hostname": "NanoStation 5AC sta name","platform": "NanoStation 5AC loco","version": "WA.ar934x.v8.7.17.48152.250620.2132","time": "2025-06-23 23:13:54","cpuload":43.564301,"temperature":0,"totalram":63447040,"freeram":14290944,"netrole": "bridge","mode": "sta-ptp","sys_id":"0xe7fa","tx_throughput":16023,"rx_throughput":251,"uptime":265320,"power_time":268512,"compat_11n":0,"signal":-58,"rssi":38,"noisefloor":-90,"tx_power":-4,"distance":1,"rx_chainmask":3,"chainrssi":[33,37,0],"tx_ratedata":[14,4,372,2223,4708,4037,8142,485763,29420892,24748154],"tx_bytes":212308148210,"rx_bytes":3624206478,"antenna_gain":13,"cable_loss":0,"height":2,"ethlist":[{"ifname": "eth0","enabled":true,"plugged":true,"duplex":true,"speed":1000,"snr":[30,30,29,30],"cable_len":14}],"ipaddr":["192.168.1.2"],"ip6addr":["fe80::eea:14ff:fea4:806"],"gps":{"lat": "52.020100","lon": "5.071400","fix":0},"oob":false,"unms":{"status":0},"airview":2,"service":{"time":267195,"link":265996}}}],"sta_disconnected":[]},"interfaces":[{"ifname": "eth0","hwaddr":"01:23:45:67:89:AB","enabled":true,"mtu":1500,"status":{"plugged":true,"tx_bytes":209900085624,"rx_bytes":3984971949,"tx_packets":185866883,"rx_packets":73564835,"tx_errors":0,"rx_errors":4,"tx_dropped":10,"rx_dropped":0,"ipaddr":"0.0.0.0","speed":1000,"duplex":true,"snr":[30,30,30,30],"cable_len":18}},{"ifname": "ath0","hwaddr":"01:23:45:67:89:AB","enabled":true,"mtu":1500,"status":{"plugged":false,"tx_bytes":5265602738,"rx_bytes":206938324766,"tx_packets":52980390,"rx_packets":149767200,"tx_errors":0,"rx_errors":0,"tx_dropped":2005,"rx_dropped":0,"ipaddr":"0.0.0.0","speed":0,"duplex":false}},{"ifname": "br0","hwaddr":"01:23:45:67:89:AB","enabled":true,"mtu":1500,"status":{"plugged":true,"tx_bytes":236295176,"rx_bytes":204802727,"tx_packets":298119,"rx_packets":1791592,"tx_errors":0,"rx_errors":0,"tx_dropped":0,"rx_dropped":0,"ipaddr":"192.168.1.2","ip6addr":[{"addr":"fe80::eea:14ff:fea4:7b8","plen":64}],"speed":0,"duplex":false}}],"provmode":{},"ntpclient":{},"unms":{"status":0},"gps":{"lat":52.020100,"lon":5.0714000,"fix":0}} | |||
| {"chain_names":[{"number":1,"name": "Chain 0"},{"number":2,"name": "Chain 1"}],"host":{"hostname": "NanoStation 5AC ap name ","device_id": "03aa0d0b40fed0a47088293584ef5432","uptime":264888,"power_time":268683,"time": "2025-06-23 23:06:42","timestamp":2668313184,"fwversion": "v8.7.17","devmodel": "NanoStation 5AC loco","netrole": "bridge","loadavg":0.412598,"totalram":63447040,"freeram":16564224,"temperature":0,"cpuload":10.101010,"height":3},"genuine": "/images/genuine.png","services":{"dhcpc":false,"dhcpd":false,"dhcp6d_stateful":false,"pppoe":false,"airview":2},"firewall":{"iptables":false,"ebtables":false,"ip6tables":false,"eb6tables":false},"portfw":false,"wireless":{"essid": "DemoSSID","mode": "ap-ptp","ieeemode": "11ACVHT80","band":2,"compat_11n":0,"hide_essid":0,"apmac":"01:23:45:67:89:AB","antenna_gain":13,"frequency":5500,"center1_freq":5530,"dfs":1,"distance":0,"security": "WPA2","noisef":-89,"txpower":-3,"aprepeater":false,"rstatus":5,"chanbw":80,"rx_chainmask":3,"tx_chainmask":3,"nol_state":0,"nol_timeout":0,"cac_state":0,"cac_timeout":0,"rx_idx":8,"rx_nss":2,"tx_idx":9,"tx_nss":2,"throughput":{"tx":222,"rx":9907},"service":{"time":267181,"link":266003},"polling":{"cb_capacity":593970,"dl_capacity":647400,"ul_capacity":540540,"use":48,"tx_use":6,"rx_use":42,"atpc_status":2,"fixed_frame":false,"gps_sync":false,"ff_cap_rep":false},"count":1,"sta":[{"mac":"01:23:45:67:89:AB","lastip":"192.168.1.2","signal":-59,"rssi":37,"noisefloor":-89,"chainrssi":[35,32,0],"tx_idx":9,"rx_idx":8,"tx_nss":2,"rx_nss":2,"tx_latency":0,"distance":1,"tx_packets":0,"tx_lretries":0,"tx_sretries":0,"uptime":170281,"dl_signal_expect":-80,"ul_signal_expect":-55,"cb_capacity_expect":416000,"dl_capacity_expect":208000,"ul_capacity_expect":624000,"dl_rate_expect":3,"ul_rate_expect":8,"dl_linkscore":100,"ul_linkscore":86,"dl_avg_linkscore":100,"ul_avg_linkscore":88,"tx_ratedata":[175,4,47,200,673,158,163,138,68895,19577430],"stats":{"rx_bytes":206938324814,"rx_packets":149767200,"rx_pps":846,"tx_bytes":5265602739,"tx_packets":52980390,"tx_pps":0},"airmax":{"actual_priority":0,"beam":0,"desired_priority":0,"cb_capacity":593970,"dl_capacity":647400,"ul_capacity":540540,"atpc_status":2,"rx":{"usage":42,"cinr":31,"evm":[[31,28,33,32,32,32,31,31,31,29,30,32,30,27,34,31,31,30,32,29,31,29,31,33,31,31,32,30,31,34,33,31,30,31,30,31,31,32,31,30,33,31,30,31,27,31,30,30,30,30,30,29,32,34,31,30,28,30,29,35,31,33,32,29],[34,34,35,34,35,35,34,34,34,34,34,34,34,34,35,35,34,34,35,34,33,33,35,34,34,35,34,35,34,34,35,34,34,33,34,34,34,34,34,35,35,35,34,35,33,34,34,34,34,35,35,34,34,34,34,34,34,34,34,34,34,34,35,35]]},"tx":{"usage":6,"cinr":31,"evm":[[32,34,28,33,35,30,31,33,30,30,32,30,29,33,31,29,33,31,31,30,33,34,33,31,33,32,32,31,29,31,30,32,31,30,29,32,31,32,31,31,32,29,31,29,30,32,32,31,32,32,33,31,28,29,31,31,33,32,33,32,32,32,31,33],[37,37,37,38,38,37,36,38,38,37,37,37,37,37,39,37,37,37,37,37,37,36,37,37,37,37,37,37,37,38,37,37,38,37,37,37,38,37,38,37,37,37,37,37,36,37,37,37,37,37,37,38,37,37,38,37,36,37,37,37,37,37,37,37]]}},"last_disc":1,"remote":{"age":1,"device_id": "d4f4cdf82961e619328a8f72f8d7653b","hostname": "NanoStation 5AC sta name","platform": "NanoStation 5AC loco","version": "WA.ar934x.v8.7.17.48152.250620.2132","time": "2025-06-23 23:13:54","cpuload":43.564301,"temperature":0,"totalram":63447040,"freeram":14290944,"netrole": "bridge","mode": "sta-ptp","sys_id":"0xe7fa","tx_throughput":16023,"rx_throughput":251,"uptime":265320,"power_time":268512,"compat_11n":0,"signal":-58,"rssi":38,"noisefloor":-90,"tx_power":-4,"distance":1,"rx_chainmask":3,"chainrssi":[33,37,0],"tx_ratedata":[14,4,372,2223,4708,4037,8142,485763,29420892,24748154],"tx_bytes":212308148210,"rx_bytes":3624206478,"antenna_gain":13,"cable_loss":0,"height":2,"ethlist":[{"ifname": "eth0","enabled":true,"plugged":true,"duplex":true,"speed":1000,"snr":[30,30,29,30],"cable_len":14}],"ipaddr":["192.168.1.2"],"ip6addr":["fe80::eea:14ff:fea4:806"],"gps":{"lat": "52.379894","lon": "4.901608","fix":0},"oob":false,"unms":{"status":0},"airview":2,"service":{"time":267195,"link":265996}}}],"sta_disconnected":[]},"interfaces":[{"ifname": "eth0","hwaddr":"01:23:45:67:89:AB","enabled":true,"mtu":1500,"status":{"plugged":true,"tx_bytes":209900085624,"rx_bytes":3984971949,"tx_packets":185866883,"rx_packets":73564835,"tx_errors":0,"rx_errors":4,"tx_dropped":10,"rx_dropped":0,"ipaddr":"0.0.0.0","speed":1000,"duplex":true,"snr":[30,30,30,30],"cable_len":18}},{"ifname": "ath0","hwaddr":"01:23:45:67:89:AB","enabled":true,"mtu":1500,"status":{"plugged":false,"tx_bytes":5265602738,"rx_bytes":206938324766,"tx_packets":52980390,"rx_packets":149767200,"tx_errors":0,"rx_errors":0,"tx_dropped":2005,"rx_dropped":0,"ipaddr":"0.0.0.0","speed":0,"duplex":false}},{"ifname": "br0","hwaddr":"01:23:45:67:89:AB","enabled":true,"mtu":1500,"status":{"plugged":true,"tx_bytes":236295176,"rx_bytes":204802727,"tx_packets":298119,"rx_packets":1791592,"tx_errors":0,"rx_errors":0,"tx_dropped":0,"rx_dropped":0,"ipaddr":"192.168.1.2","ip6addr":[{"addr":"fe80::eea:14ff:fea4:7b8","plen":64}],"speed":0,"duplex":false}}],"provmode":{},"ntpclient":{},"unms":{"status":0},"gps":{"lat":53.379894,"lon":4.901608,"fix":0}} | |||
There was a problem hiding this comment.
Suspicious off-by-one-degree latitude on remote device
"wireless"→"sta"[0]→"remote"→"gps" now reads
"lat": "52.379894"whereas:
• The host AP latitude (top-level "gps") is 53.379894
• The peer STA latitude in fixtures/sta-ptp.json is also 53.379894
A one-degree (~111 km) gap looks like a typo (52 ↔ 53). If the intent was to mirror the STA fixture, update the value:
-"lat": "52.379894"
+"lat": "53.379894"Failing to align the fixtures may break tests comparing the two sides of the link.
🤖 Prompt for AI Agents
In fixtures/ap-ptp.json at line 1, the latitude value under
"wireless"→"sta"[0]→"remote"→"gps" is "52.379894", which is off by one degree
compared to the host AP latitude "53.379894" and the peer STA latitude in
fixtures/sta-ptp.json. To fix this, update the "lat" value in the remote gps
object to "53.379894" to align it with the other fixtures and avoid test
failures due to this discrepancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit