Improve consume function

[CoMPaTech]

Summary by CodeRabbit

• Chores
  • Updated project version to 0.2.3.
  • Disabled markdownlint rule MD024 to allow repeated headers in documentation.
  • Increased test coverage threshold to 85% for quality enforcement.
• Bug Fixes
  • Improved error handling by raising exceptions on device connection failures.
• Tests
  • Added comprehensive asynchronous tests covering device login, status checks, and feature controls.

[coderabbitai]

Walkthrough

The _async_airos_device_found callback within async_discover_devices in airos/discovery.py was converted from a synchronous to an asynchronous function, altering the expected callback signature for AirOSDiscoveryProtocol. Additionally, a debug log statement was removed. The project version in pyproject.toml was incremented to "0.2.3". The .markdownlint.yaml file was updated to disable the MD024 rule. The airos8.py module was modified to always read response text before checking HTTP status and to raise an exception on non-200 responses. A new test module tests/test_airos8.py was added with comprehensive async tests for airos8.py. The GitHub workflow coverage threshold was increased from 80% to 85%.

Changes

Cohort / File(s)	Change Summary
Discovery Callback Refactor airos/discovery.py	Changed _async_airos_device_found from synchronous to asynchronous; removed a debug log statement.
Project Version Bump pyproject.toml	Updated project version from "0.2.2" to "0.2.3".
Markdownlint Configuration Update .markdownlint.yaml	Disabled markdownlint rule MD024 to allow multiple headers with the same content.
AirOS8 HTTP Response Handling airos/airos8.py	Always awaited response text before status check; raised AirOSDeviceConnectionError on non-200 status.
New Async Tests for AirOS8 tests/test_airos8.py	Added comprehensive async pytest tests covering login, status, derived_data, stakick, and provmode methods with error and flow scenarios.
CI Coverage Threshold Increase .github/workflows/verify.yml	Increased coverage fail-under threshold from 80% to 85%.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant Discovery as async_discover_devices
    participant Protocol as AirOSDiscoveryProtocol
    participant Callback as _async_airos_device_found

    Caller->>Discovery: Call async_discover_devices()
    Discovery->>Protocol: Instantiate with async callback
    Protocol-->>Callback: Await _async_airos_device_found(device_info)
    Callback-->>Protocol: Complete async callback
    Protocol-->>Discovery: Device discovery completes
    Discovery-->>Caller: Return discovered devices

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Add discovery and improve consistency #33: Modifies the callback signature expected by AirOSDiscoveryProtocol, directly related to the callback refactor in this PR.
• Improvements #37: Adds async_discover_devices and renames AirosDiscoveryProtocol to AirOSDiscoveryProtocol, closely tied to the callback changes in the same file.

Suggested labels

enhancement

Poem

A callback once plain, now awaits with a smile,
Devices discovered in asynchronous style.
The version hops up, a new alpha to see,
Debug logs trimmed for clarity.
Response text read, errors now caught tight,
Tests hop in to keep code just right.
A rabbit’s delight in the soft glowing light! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c6ac87 and 869b27e.

📒 Files selected for processing (3)

• .github/workflows/verify.yml (1 hunks)
• CHANGELOG.md (1 hunks)
• pyproject.toml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• pyproject.toml
• .github/workflows/verify.yml
• CHANGELOG.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Process test coverage

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch testing

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[CoMPaTech]

@coderabbitai can you re review and update the summary (your process is hanging or faulted)

[coderabbitai]

@CoMPaTech I'll re-review the entire PR and update the summary for you. Let me trigger a fresh review process.

✅ Actions performed

Summary regeneration triggered.

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud