Skip to content

Conversation

GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Jun 25, 2025

fixes #11

Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #14 will not alter performance

Comparing cod-1032-warnings-generated-when-building-workerd (d68b802) with main (308c879)

Summary

✅ 42 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed WallTime Performance Report

Merging #14 will degrade performances by 33.33%

Comparing cod-1032-warnings-generated-when-building-workerd (d68b802) with main (308c879)

Summary

⚡ 4 improvements
❌ 4 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BarTest[MyFixture] < 1 ns < 1 ns +20%
DoubleTest[MyTemplatedFixture, double] < 1 ns < 1 ns -16.67%
IntTest[MyTemplatedFixture, int] < 1 ns < 1 ns -33.33%
TestA[MyTemplate1, int] < 1 ns < 1 ns -20%
TestB[MyTemplate2, int, double] < 1 ns < 1 ns +20%
BM_Capture[int_string_test] < 1 ns < 1 ns -16.67%
BM_Capture[int_test] < 1 ns < 1 ns +20%
BM_Template1_Capture[two_type_test, int, double] < 1 ns < 1 ns +20%

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1032-warnings-generated-when-building-workerd branch 3 times, most recently from 11c0470 to a347eaa Compare June 25, 2025 15:59
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1032-warnings-generated-when-building-workerd branch from a347eaa to d68b802 Compare June 25, 2025 16:11
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GuillaumeLagrange GuillaumeLagrange merged commit d68b802 into main Jun 25, 2025
8 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1032-warnings-generated-when-building-workerd branch June 25, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings generated when building workerd

2 participants