Add codspeed instrumentation support for google benchmark #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
7 times, most recently
from
967e2d1 to
11f563e
Compare
CodSpeed Instrumentation Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
3 times, most recently
from
8fceb44 to
4601025
Compare
art049
reviewed
Feb 24, 2025
|
As discussed, we need to generate the debug symbols as well |
|
Also, please use a better cmake formater |
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
4 times, most recently
from
a4d52fb to
1fe4db9
Compare
By default in the example, debug symbols are present. I think the best wya to handle this will be to have a specific callout to make sure the users enable debug symbols when building, not much more we can do as a bench library |
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
8 times, most recently
from
8271fbd to
582a6d5
Compare
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
3 times, most recently
from
bf3c469 to
fb9bf9b
Compare
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
from
fb9bf9b to
dbbabfb
Compare
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
from
dbbabfb to
0a4db23
Compare
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
from
0a4db23 to
3830af0
Compare
art049
requested changes
Mar 7, 2025
Comment on lines
+468
to
+471
| b.Setup(); | ||
| State st = b.RunInstrumented(CodSpeed::getInstance(), &timer, manager.get(), | ||
| nullptr, nullptr); | ||
| b.Teardown(); |
There was a problem hiding this comment.
Is the original behavior to call setup and teardown just once before and after all the iterations? (instead of running before/after each iteration)? We might create some inconsistencies if that's not the case
This makes sure that we only give metadata to valgrind once.
GuillaumeLagrange
force-pushed
the
cod-288-support-instrumentation-withgooglebenchmark
branch
from
3830af0 to
4772cff
Compare
art049
approved these changes
Mar 7, 2025
GuillaumeLagrange
deleted the
cod-288-support-instrumentation-withgooglebenchmark
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.