fix(bazel): expose codspeed_mode flag #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My root module depends transitively on codspeed through an intermediary. It does not depend on it directly with a `bazel_dep` in MODULE.bazel. Thus I cannot set `--@codspeed//core:codspeed_mode` on my command line - in bzlmod that's a strict visibility violation. The intermediary should provide an alias to set the mode. This requires the flag to be public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My root module depends transitively on codspeed through an intermediary. It does not depend on it directly with a
bazel_depin MODULE.bazel.Thus I cannot set
--@codspeed//core:codspeed_modeon my command line - in bzlmod that's a strict visibility violation. The intermediary should provide an alias to set the mode. This requires the flag to be public.