Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

instrumentation is still accepted as an input, but it maps to simulation internally, as we plan to phase it out.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #36 will not alter performance

Comparing cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now (bee1708) with main (20ab8dc)1

Summary

✅ 192 untouched

Footnotes

  1. No successful run was found on main (bee1708) during the generation of this report, so 20ab8dc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review November 17, 2025 17:19
@GuillaumeLagrange GuillaumeLagrange changed the title feat: accept rename instrumentation to simulation feat: rename instrumentation to simulation Nov 17, 2025
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

`instrumentation` is still accepted as an input, but it maps to
simulation internally, as we plan to phase it out.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch from 6d02bb9 to bee1708 Compare November 20, 2025 10:25
@GuillaumeLagrange GuillaumeLagrange merged commit bee1708 into main Nov 20, 2025
24 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch November 20, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants