-
Notifications
You must be signed in to change notification settings - Fork 2
fix(google_benchmark): generate proper uri #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google_benchmark): generate proper uri #5
Conversation
CodSpeed Instrumentation Performance ReportMerging #5 will not alter performanceComparing Summary
Benchmarks breakdown
|
CodSpeed Walltime Performance ReportMerging #5 will not alter performanceComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the rule to build URIs should be
the base name (i.e the part after the last ::
) of the benchmark should be the name of either the function of the template
the arguments should be in order
- the name of the test case
- the template type argument
- the function extra arguments
New URI:
Original URI:
NOTE: There also seems to be an issue in this one: |
7be070f
to
6a7b505
Compare
891ae51
to
891d999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d4a0cf2
to
4686610
Compare
With CODSPEED_MODE:
Without CODSPEED_MODE: