Skip to content

Conversation

art049
Copy link
Member

@art049 art049 commented May 12, 2025

No description provided.

@art049 art049 requested a review from GuillaumeLagrange May 12, 2025 19:57
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #9 will not alter performance

Comparing fix-header-warnings (796b1a6) with main (bf30684)

Summary

✅ 42 untouched benchmarks

Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Walltime Performance Report

Merging #9 will degrade performances by 44.44%

Comparing fix-header-warnings (796b1a6) with main (bf30684)

Summary

⚡ 4 improvements
❌ 4 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BarTest[MyFixture] < 1 ns < 1 ns +20%
DoubleTest[MyTemplatedFixture, double] < 1 ns < 1 ns -33.33%
FooTest[MyFixture] < 1 ns < 1 ns -44.44%
TestA[MyTemplate1, int] < 1 ns < 1 ns -16.67%
TestB[MyTemplate2, int, double] < 1 ns < 1 ns -16.67%
BM_Capture[int_string_test] < 1 ns < 1 ns +50%
BM_rand_vector < 1 ns < 1 ns +20%
BM_Template1_Capture[int_string_test] < 1 ns < 1 ns +20%

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we should also add the option in the .bazelrc to make sure we don't break this anymore

@art049 art049 merged commit 796b1a6 into main May 12, 2025
8 checks passed
@art049 art049 deleted the fix-header-warnings branch May 12, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants