-
Notifications
You must be signed in to change notification settings - Fork 0
feat: codspeed go add perf v2 support #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
not-matthias
wants to merge
10
commits into
main
Choose a base branch
from
cod-1378-codspeed-go-add-perf-v2-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e4cc76c
fix(ci): run go-runner in release mode
not-matthias 58d4242
fix(ci): run benchmarks of all packages
not-matthias 45673f9
feat(example): add bench with setup
not-matthias fde54be
fix(ci): use sharded walltime runs
not-matthias c096497
fix(example): move sleep tests to own package
not-matthias 9eff5c9
fix(testing): benchTime is already in seconds
not-matthias 7cc4b44
fix(testing): remove wrong reset timer
not-matthias e674755
chore(testing): bump instrument-hooks
not-matthias 944050f
fix(testing): dont append to list before stopping testing timer
not-matthias 8ee14f6
feat(testing): add benchmark markers
not-matthias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package example | ||
|
|
||
| import "time" | ||
|
|
||
| //go:noinline | ||
| func recursiveFib(n int) uint64 { | ||
| if n <= 1 { | ||
| return uint64(n) | ||
| } | ||
| return recursiveFib(n-1) + recursiveFib(n-2) | ||
| } | ||
|
|
||
| //go:noinline | ||
| func expensiveOperation() uint64 { | ||
| // Large memory allocation | ||
| data := make([]uint64, 1024*1024) // 8 MiB allocation | ||
| for i := range data { | ||
| data[i] = 42 | ||
| } | ||
|
|
||
| // Expensive recursive computation that will dominate flamegraph | ||
| fibResult := recursiveFib(30) | ||
|
|
||
| // More expensive work - sum the data | ||
| sum := uint64(0) | ||
| for _, v := range data { | ||
| sum += v | ||
| } | ||
|
|
||
| return sum + fibResult | ||
| } | ||
|
|
||
| //go:noinline | ||
| func doWork(n int) uint64 { | ||
| if n <= 1 { | ||
| return uint64(n) | ||
| } | ||
| return doWork(n-1) + doWork(n-2) | ||
| } | ||
|
|
||
| func actualWork() uint64 { | ||
| time.Sleep(1 * time.Millisecond) | ||
| result := doWork(30) | ||
| return 42 + result | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package example | ||
|
|
||
| import ( | ||
| "runtime" | ||
| "testing" | ||
| ) | ||
|
|
||
| func BenchmarkLargeSetup(b *testing.B) { | ||
| expensiveOperation() | ||
| b.ResetTimer() | ||
|
|
||
| var result uint64 | ||
| for i := 0; i < b.N; i++ { | ||
| result = actualWork() | ||
| } | ||
| runtime.KeepAlive(result) | ||
| } | ||
|
|
||
| func BenchmarkLargeSetupInLoop(b *testing.B) { | ||
| var result uint64 | ||
| for i := 0; i < b.N; i++ { | ||
| b.StopTimer() | ||
| expensiveOperation() | ||
| b.StartTimer() | ||
|
|
||
| result = actualWork() | ||
| } | ||
| runtime.KeepAlive(result) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package example | ||
| package timing | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same feedback as in the Python PR, if there is a way to avoid duplicating this, it would be great