-
Notifications
You must be signed in to change notification settings - Fork 0
Cod 1173 build golang tests with codspeed instrumentation in runner #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cod 1173 build golang tests with codspeed instrumentation in runner #4
Conversation
f8a0011
to
a412fea
Compare
02935b0
to
72c9f67
Compare
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
a412fea
to
0ba720d
Compare
72c9f67
to
62cce6d
Compare
507a96a
to
7859c4c
Compare
62cce6d
to
58ad476
Compare
f26e3f3
to
b2d863e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
olgtm,
watch out some commits are unverified tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really cool! Excited to see it working
go-runner/testdata/raw_results/0e63aecf81ebd4160bcb4533a480bc22.json
Outdated
Show resolved
Hide resolved
877a3c6
to
6aac26f
Compare
6aac26f
to
563e79d
Compare
a03f4dd
to
55cf82d
Compare
55cf82d
to
e6c78e5
Compare
Continuation from #3 : Accidentally pushed
target
during a rebase and let Claude fix it, which closed the PR(?)The process is split into multiple parts:
t *testing.B
parameter isn't passed to a function.cli/runner.go
main file with the benchmarks.testing
to our codspeed compat packagecli/runner.go
and outputs the binary.