Skip to content

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Jul 28, 2025

If target.<cfg>.rustflags is set, our build.rustflags config value won't be used since it has a lower precedence (see: https://doc.rust-lang.org/nightly/cargo/reference/config.html#buildrustflags). We can solve this by using target.cfg(all()) but this will override any build.rustflags values in the .cargo/config.toml.

Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed Instrumentation Performance Report

Merging #114 will degrade performances by 15.89%

Comparing cod-1187-cargo-codspeed-not-building-properly-with-304-on-swc (88f18b7) with main (2d80483)

Summary

⚡ 7 improvements
❌ 5 regressions
✅ 155 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
sleep_100ms 624.4 ns 595.3 ns +4.9%
sleep_10ms 595.3 ns 566.1 ns +5.15%
sleep_1ms 595.3 ns 566.1 ns +5.15%
sleep_50ms 624.4 ns 595.3 ns +4.9%
bench_array1[10] 195.8 ns 225 ns -12.96%
bench_array1[4] 154.4 ns 183.6 ns -15.89%
bench_array2[10] 195.8 ns 225 ns -12.96%
bench_array2[4] 154.4 ns 183.6 ns -15.89%
init_array[4] 154.4 ns 183.6 ns -15.89%
recursive_memoized[BTreeMap<u64, u64>, 0] 371.7 ns 342.5 ns +8.52%
instant 363.6 ns 334.4 ns +8.72%
system_time 363.6 ns 334.4 ns +8.72%

Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed WallTime Performance Report

Merging #114 will degrade performances by 58.52%

Comparing cod-1187-cargo-codspeed-not-building-properly-with-304-on-swc (88f18b7) with main (2d80483)

Summary

⚡ 14 improvements
❌ 8 regressions
✅ 132 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
large_drop 166.6 µs 188.1 µs -11.4%
large_setup 13 ns 15 ns -13.33%
from_elem[16384] 836 ns 863 ns -3.13%
from_elem[4096] 332 ns 321 ns +3.43%
from_elem[8192] 494 ns 510 ns -3.14%
bench_array1[10] 10 ns 9 ns +11.11%
bench_array2[10] 10 ns 9 ns +11.11%
recursive_memoized[BTreeMap<u64, u64>, 20] 1.9 µs 1.8 µs +5.96%
recursive_memoized[BTreeMap<u64, u64>, 30] 3.1 µs 3 µs +4.05%
recursive_memoized[BTreeMap<u64, u64>, 5] 214 ns 199 ns +7.54%
recursive_memoized[HashMap<u64, u64>, 10] 1.6 µs 1.5 µs +5.27%
recursive_memoized[HashMap<u64, u64>, 5] 627 ns 573 ns +9.42%
graph_coloring[3] 1.2 µs 1.1 µs +5.5%
hamiltonian_cycle[5] 636 ns 662 ns -3.93%
permutations[5] 14 µs 13.4 µs +4.76%
add_two_integers[(255, 255)] 20 ns 6 ns ×3.3
add_two_integers[(42, 13)] 20 ns 6 ns ×3.3
system_time 38 ns 40 ns -5%
sleep_100ns 24 µs 57.8 µs -58.52%
sleep_100us 126.5 µs 113.1 µs +11.86%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-1187-cargo-codspeed-not-building-properly-with-304-on-swc branch 3 times, most recently from 21e72e1 to a5b0ee0 Compare July 29, 2025 12:15
@not-matthias not-matthias requested a review from art049 July 29, 2025 12:16
@not-matthias not-matthias force-pushed the cod-1187-cargo-codspeed-not-building-properly-with-304-on-swc branch from a5b0ee0 to b648598 Compare July 29, 2025 12:17
…the .cargo/config.toml

When using build.rustflags, it won't be merged because it has a lower precedence. See: https://doc.rust-lang.org/nightly/cargo/reference/config.html#buildrustflags
@not-matthias not-matthias force-pushed the cod-1187-cargo-codspeed-not-building-properly-with-304-on-swc branch from dd12b10 to 88f18b7 Compare July 30, 2025 12:46
@not-matthias not-matthias requested a review from art049 July 31, 2025 09:04
@not-matthias not-matthias merged commit 88f18b7 into main Jul 31, 2025
13 of 14 checks passed
@not-matthias not-matthias deleted the cod-1187-cargo-codspeed-not-building-properly-with-304-on-swc branch July 31, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants