Skip to content

Replace cargo api crate by cargo cli invocations #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Replace cargo api crate by cargo cli invocations #63

merged 1 commit into from
Jan 28, 2025

Conversation

@GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Jan 24, 2025 •
edited
Loading

Removes usage of cargo lib in favor of the recommended way of using cargo from cli

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch 2 times, most recently from 865633b to 333032b Compare January 24, 2025 07:59
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #63 will improve performances by 11.45%

Comparing cod-405-cargo_term_color-is-not-respected (7dcd871) with main (280d7a0)

Summary

⚡ 1 improvements
✅ 53 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ sum_fold 283.9 ns 254.7 ns +11.45%

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch from 333032b to db049a6 Compare January 24, 2025 07:59
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch from db049a6 to fc96ea5 Compare January 24, 2025 08:08
@GuillaumeLagrange GuillaumeLagrange changed the title cod 405 cargo term color is not respected Replace cargo api crate by cargo cli usage Jan 24, 2025
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch 10 times, most recently from de2397d to 0c752e0 Compare January 24, 2025 14:03
@GuillaumeLagrange GuillaumeLagrange changed the title Replace cargo api crate by cargo cli usage Replace cargo api crate by cargo cli invocations Jan 24, 2025
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch 2 times, most recently from 6e12727 to 2dcbd24 Compare January 24, 2025 14:20
@GuillaumeLagrange GuillaumeLagrange linked an issue Jan 26, 2025 that may be closed by this pull request
Use the cargo CLI instead of the API #50
Closed
art049
art049 requested changes Jan 27, 2025
View reviewed changes
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch 5 times, most recently from ac01a83 to f3ee768 Compare January 27, 2025 13:14
art049
art049 requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, instead of “whitelist” and “blacklist" we can use “allowlist” and “denylist”

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch from 207760c to 02e48dc Compare January 27, 2025 16:37
@GuillaumeLagrange
feat(cargo-codspeed): use cargo from cli
7dcd871 
Local rustflags have be moved to cargo config.
Before this, the .vscode/settings.json was setting a `RUSTFLAGS` value
that was not shared by the cargo cli version, causing unneccessary
rebuilds between `cargo build` and an editor save.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-405-cargo_term_color-is-not-respected branch from 02e48dc to 7dcd871 Compare January 28, 2025 09:02
@GuillaumeLagrange GuillaumeLagrange merged commit a22fb70 into main Jan 28, 2025
4 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-405-cargo_term_color-is-not-respected branch January 28, 2025 09:03
@GuillaumeLagrange GuillaumeLagrange linked an issue Jan 29, 2025 that may be closed by this pull request
CARGO_TERM_COLOR is not respected #61
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art049 art049 art049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CARGO_TERM_COLOR is not respected Use the cargo CLI instead of the API

2 participants

@GuillaumeLagrange @art049