Skip to content

feat: add samply profiler support #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 17 commits into from
May 12, 2026
Merged

feat: add samply profiler support #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
12954df
feat(walltime): add Profiler trait abstraction
not-matthias May 1, 2026
f257741
refactor(walltime): rename IntegrationMode::Perf to Walltime
not-matthias May 1, 2026
5225a44
refactor(walltime): rename FifoCommand::PingPerf to PingProfiler
not-matthias May 1, 2026
6da53e4
refactor(walltime): move perf module under profiler/
not-matthias May 1, 2026
4e386c7
refactor(walltime): rename PerfMetadata to WalltimeMetadata
not-matthias May 1, 2026
d2e4e27
refactor(walltime): port PerfRunner to Profiler trait
not-matthias May 1, 2026
8d3f214
feat(walltime): rename CODSPEED_PERF_ENABLED to CODSPEED_PROFILER_ENA…
not-matthias May 4, 2026
1d708e3
fix(fifo): use O_RDWR to open FIFOs on all Unix platforms
not-matthias May 5, 2026
98a2621
fix(walltime): use mach_absolute_time for FIFO timestamps on macOS
not-matthias May 5, 2026
f3257ee
feat(walltime): add samply profiler for macOS
not-matthias May 5, 2026
43d9e50
refactor(walltime): share Linux profiler sysctl setup
not-matthias May 7, 2026
2e85913
feat(walltime): bundle samply via library crate
not-matthias May 7, 2026
f94e5b3
fix(walltime): disable PYTHON_PERF_JIT_SUPPORT on macOS
not-matthias May 7, 2026
cdc098a
refactor(walltime): rename Profiler::wrap to wrap_command
not-matthias May 8, 2026
56e27df
refactor: rename Benchmark FIFO commands/markers to Profiler/Round
not-matthias May 8, 2026
9cf182e
ci: disable profiler in macos-basic-run-test
not-matthias May 12, 2026
d32d356
refactor(cli): centralize internal re-exec via InternalCommands::get_…
not-matthias May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ jobs:
cargo install --path crates/exec-harness --locked

- name: Run tests
env:
# Profiling system commands (e.g. `ls`) with samply is not yet supported on MacOS
CODSPEED_PROFILER_ENABLED: "false"
Comment thread
not-matthias marked this conversation as resolved.
run: cargo run -- exec -m walltime --skip-upload --warmup-time 0s --max-rounds 5 -- ls -la

bpf-tests:
Expand Down
Loading