-
Notifications
You must be signed in to change notification settings - Fork 15
Stop pulling unused cffi as a direct dependency in core packaging metadata #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
|
Seems there's a bit of the problem in the uv setup. Perhaps cffi needs to be removed from the uv.lock file? |
|
Yes |
|
@webknjaz if you don't have the time currently I would be willing to fork your patch-1 and then commit it. I can't seem to create a reviewer's suggestion. But I could quickly fork and pull request to your branch. |
|
Sounds good, thanks! |
|
@art049 could you run the CI again? |
|
@art049 do you happen to know how to remove the cffi dependency by any chance? even I'm having trouble making edits and I use uv a lot for many of my numerous libraries. |
I think it's caused by an old version of uv: I opened #95. |
Removed cffi package version 1.17.1 and its dependencies from the lock file.
INTERNALERROR> RuntimeError: Failed to load instrument hooks library: No module named '_cffi_backend'@Vizonex looks like the dep should be added to the test deps. Would you like to give it a try? |
|
Hey @webknjaz, @Vizonex, @edgarrmondragon. After taking a closer look it was not that easy to remove |
|
@adriencaccia Thanks. This will definitely save both me and webknjaz a headache. |
Fixes #86