Skip to content

Bump uv in CI from 0.5.20 to 0.9.5 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2025
Merged

Bump uv in CI from 0.5.20 to 0.9.5 #95

merged 3 commits into from
Oct 28, 2025

Conversation

@edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Oct 28, 2025 •
edited
Loading

@edgarrmondragon edgarrmondragon mentioned this pull request Oct 28, 2025
Open
edgarrmondragon
edgarrmondragon commented Oct 28, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
- uses: astral-sh/setup-uv@v4
with:
version: "0.5.20"
version: "0.9.5"
Copy link
Contributor Author

@edgarrmondragon edgarrmondragon Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably, >=0.9.5,<0.10 would be better

Copy link

@Vizonex Vizonex Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not really have a say but it seems like it will do a pretty good job

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #95 will degrade performances by 15.46%

Comparing edgarrmondragon:bump-uv (de1f61c) with master (66afb84)

Summary

⚡ 16 improvements
❌ 29 (👁 29) regressions
✅ 122 untouched

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
👁 WallTime test_iir_filter_process 2.6 µs 2.6 µs -2.06%
👁 WallTime test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 827 ns 890.7 ns -7.15%
👁 WallTime test_make_allpass 5 µs 5.3 µs -5.68%
⚡ WallTime test_make_highpass 5.6 µs 5.4 µs +4.34%
⚡ WallTime test_make_highshelf 7.4 µs 7.2 µs +2.92%
⚡ WallTime test_make_lowshelf 7.4 µs 7.2 µs +2.06%
👁 WallTime test_make_peak 6 µs 6.2 µs -3.49%
👁 WallTime test_color[graph0-3] 26.3 µs 27.5 µs -4.37%
👁 WallTime test_combination_lists[0-0] 1.8 µs 1.9 µs -2.6%
👁 WallTime test_combination_lists[4-2] 3.7 µs 3.8 µs -3.25%
👁 WallTime test_combination_lists[5-4] 3.3 µs 3.4 µs -2.88%
👁 WallTime test_generate_all_combinations[0-0] 1.1 µs 1.2 µs -5.34%
⚡ WallTime test_generate_all_combinations[4-2] 7.4 µs 6.6 µs +11.14%
👁 WallTime test_generate_all_combinations[5-4] 9.7 µs 10 µs -3.58%
⚡ WallTime test_generate_all_permutations[sequence0] 159.2 µs 155.4 µs +2.46%
👁 WallTime test_generate_parenthesis[3] 11.4 µs 11.8 µs -2.82%
👁 WallTime test_generate_sum_of_subsets_soln[nums0-9] 22.4 µs 23.3 µs -4.07%
⚡ WallTime test_is_complete[board0] 1.8 µs 1.8 µs +2.8%
⚡ WallTime test_minimax[scores0] 7.8 µs 7.6 µs +3.5%
👁 WallTime test_open_knight_tour[1] 3.7 µs 3.8 µs -2.63%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Vizonex
Vizonex approved these changes Oct 28, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
- uses: astral-sh/setup-uv@v4
with:
version: "0.5.20"
version: "0.9.5"
Copy link

@Vizonex Vizonex Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not really have a say but it seems like it will do a pretty good job

adriencaccia
adriencaccia approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edgarrmondragon

@adriencaccia adriencaccia merged commit a71ec50 into CodSpeedHQ:master Oct 28, 2025
36 checks passed
@edgarrmondragon edgarrmondragon deleted the bump-uv branch October 28, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriencaccia adriencaccia adriencaccia approved these changes

+1 more reviewer

@Vizonex Vizonex Vizonex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarrmondragon @adriencaccia @Vizonex