Feat: add the exec subcommand to run an arbitrary rust binary #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This binary is in charge of providing a minimal instrument-hooks wrapper around the command it is given.
GuillaumeLagrange
force-pushed
the
cod-1723-run-an-hello-world-rust-binary-in-the-runner-in-walltime
branch
from
66623cf to
1df9f70
Compare
Refactor aims to extract common behavior between exec and run. It mostly moves out the run::Config into the executor module, as well as moving the run_environment module to the root of the repo. The main aim is to offload the overloaded run module that has outgrown its initial purpose of a clap subcommand.
GuillaumeLagrange
force-pushed
the
cod-1723-run-an-hello-world-rust-binary-in-the-runner-in-walltime
branch
from
1df9f70 to
e597063
Compare
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
Look good! I like the new structure 👍
GuillaumeLagrange
force-pushed
the
cod-1723-run-an-hello-world-rust-binary-in-the-runner-in-walltime
branch
from
cc8e299 to
ac44deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_envas I have seen this kind of stuff in the pastprocess::waitdespite the trace-children argumentStill, I think it's worth it to have a first review for the refactor part, just to make sure we are aware of potential conflicts with #164