MudSelectExtended: Fix disabled and readonly state when parent is disabled or readonly #558
Conversation
…abled or readonly
|
Sorry, whacked the approve button on this because I need this change to go in, but I don't have write access. Didn't think it would work but I was curious! |
all good! Hopefully someone with write access will have a look at this PR :D |
|
It's not working as intended. It still behaves like readonly, the colored underline shows and label shrinks when click on component. |
The component does not open the popover but yeah, you're right and the UI still shows the readonly behaviour. But I need a hand with that one. Any help would be very much appreciated :D |
|
MudComboBox works properly. It has same classnames like mud-select-extended. We can focus on differences between select and combobox. And we should find which release break this behavior. Probably one of the core library release caused this behavior. |
|
This PR fixes this issue partially. Im merging it now, thanks for the effort. But we should investigate the design issue. |
3 participants
Fixes #557
MudSelectExtended.razor.cs: RefactoredDisabledandReadOnlychecks to use centralized methods (GetDisabledStateandGetReadOnlyState).DisabledParentSelectTest.razor: Added a new test component to verifyMudSelectExtendedbehavior when wrapped in a disabled parent.SelectTest1.razor: Added aDisabledparameter toMudSelectExtendedand refactored event handling methods.SelectExtendedTests.cs: Added two new test cases to validateMudSelectExtendedbehavior when disabled or when its parent is disabled.