Conversation
Things I noticed when reading over the code. - Conversions to more idiomatic code. - Spelling fixes. - Minor comment improvements. - Some minor formatting changes. Signed-off-by: Nicholas Nethercote <n.nethercote@gmail.com>
|
Apologies for the unconnected changes all dumped in a single commit. Lots of opinions here, I'm happy to undo any that rankle. The code quality across the whole repository is generally very good, based on the skimming that I did. |
| &mut self, | ||
| mut comm: R, | ||
| req: &PldmRequest<'_>, | ||
| host: &mut impl Host, |
There was a problem hiding this comment.
So we currently have this under the assumption that anything more complex than the current (ie., very basic) file host implementation would need interactions with the host at least for DfOpen operations.
I am happy to remove it now, but we'd likely need it back shortly - which would be an API-breaking change. That said, that change would also modify the Host trait, so we'd have breakages there anyway.
Removing the host arg from the cmd_ handlers is fine though.
There was a problem hiding this comment.
I haven't removed it, precisely because it's public. Changing from host to _host is just needed to prevent the compiler complaining about the unused arg.
There was a problem hiding this comment.
hah, I had been focusing all on the - side of the series. All good then!
|
Thanks for those |
3 participants
Things I noticed when reading over the code.