estack: Convert serial transport to packet-transfer-style API #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk-ozlabs
force-pushed
the
pr/serial-api
branch
2 times, most recently
from
b671f12 to
42c7f5d
Compare
mkj
approved these changes
Jun 4, 2025
| let _ = self.mctp.update(self.now()); | ||
| let cookie = None; | ||
| let r = self.mctpserial.send_fill( | ||
| let mut fragmenter = self.mctp.start_send( |
Member
There was a problem hiding this comment.
I'd consider revamping standalone to use Router and then serial.rs would be two simpler loops. That can be done later though.
Member
Author
There was a problem hiding this comment.
I was debating doing that, but settled on the direct stack approach as a minimum change. Happy to convert later if Router makes more sense in general.
Currently, MctpSerialHandler's public API gets passed a mctp::Stack
object, and interacts with that for packet receive/transmit.
Newer-style end-usage of the stack objects tends to use the routing
infrastructure though, which uses a simpler packet tx/rx interface to the
transport (ie, populating [u8]s rather than handling the MCTP packets
internally). This change converts the current interface to:
pub async fn recv_async(
&mut self,
input: &mut impl Read,
) -> mctp::Result<&[u8]> {
pub async fn send_async(
&mut self,
pkt: &[u8],
output: &mut impl Write,
) -> mctp::Result<()> {
- which is easier to glue into the routing interface.
In doing this, convert the standalone crate to use the new
MctpSerialHandler API, where it needs to own the mctp::Stack internally.
Signed-off-by: Jeremy Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MctpSerialHandler's public API gets passed a mctp::Stack object, and interacts with that for packet receive/transmit.
Newer-style end-usage of the stack objects tends to use the routing infrastructure though, which uses a simpler packet tx/rx interface to the transport (ie, populating [u8]s rather than handling the MCTP packets internally). This change converts the current interface to:
- which is easier to glue into the routing interface.
In doing this, convert the standalone crate to use the new MctpSerialHandler API, where it needs to own the mctp::Stack internally.