Skip to content

Conversation

@CodeDredd
Copy link
Owner

@CodeDredd CodeDredd commented Dec 26, 2022

πŸ”— Linked issue

related #774

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since all() ignores the query builder it shouldn't be able to be called from the query builder. This helps to have more exspected results so that useRepo(User).all() is correct but useRepo(User).query().all() not.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

BREAKING-CHANGE: make `all()` not accessible from query
@CodeDredd CodeDredd added the enhancement New feature or request label Dec 26, 2022
@CodeDredd CodeDredd self-assigned this Dec 26, 2022
@CodeDredd CodeDredd added this to the 2.0.0 milestone Dec 26, 2022
@CodeDredd CodeDredd merged commit a79d76f into release/2.0.0 Dec 26, 2022
@CodeDredd CodeDredd deleted the change-all branch December 26, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants