Skip to content

Conversation

@CodeDredd
Copy link
Owner

@CodeDredd CodeDredd commented Jan 3, 2023

πŸ”— Linked issue

related to #774

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This refactoring brings more consistency to the insert, save & update functions. It also adds the missing update
function on repository level.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@mllull
Copy link

mllull commented Jan 12, 2023

First of all, congratulations! This library is awesome πŸŽ‰ Thanks for you effort on improving it!

I'm glad to see that now I could use insert method and keep relationships saved! Today I had to change all my SomeLib.fresh(data) calls with this combination of code to keep relations and not break my code:

SomeLib.flush();
SomeLib.save(data);

I understand that with this PR now the fresh function will preserve models relationships, is it?

I see this PR very usefull, many thanks! πŸ‘

@CodeDredd
Copy link
Owner Author

CodeDredd commented Jan 22, 2023

@mllull nice to hear that...but as you noticed i havn't merged it for 1.5.0 because it's a breaking change for insert. So this PR will be the start for v2.0.0 i guess. ^^

understand that with this PR now the fresh function will preserve models relationships, is it?

Yes.

@CodeDredd CodeDredd added enhancement New feature or request breaking-changes Introducing new BREAKING CHANGES labels Jan 22, 2023
@CodeDredd CodeDredd added this to the 2.0.0 milestone Jan 22, 2023
Base automatically changed from next-release to master January 24, 2023 11:19
@CodeDredd CodeDredd removed the breaking-changes Introducing new BREAKING CHANGES label Sep 20, 2023
@CodeDredd CodeDredd removed this from the 2.0.0 milestone Sep 20, 2023
@CodeDredd CodeDredd added the breaking-changes Introducing new BREAKING CHANGES label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes Introducing new BREAKING CHANGES enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants