Skip to content

@/trustlab payload improvements #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kilemensi merged 8 commits into from
May 29, 2025
Merged

@/trustlab payload improvements #1175

kilemensi merged 8 commits into from
May 29, 2025

Conversation

@kilemensi
Copy link
Member

@kilemensi kilemensi commented May 29, 2025

Description

  • Enable disable APIs in /admin based on site.environment (using SENTRY_ENVIRONMENT).
  • Simplify localized: true in Group fields i.e. no need to enable in nested fields since enabling it at group level ensures everything inside the group is localised.
  • Ensure only loggedIn users can read settings as it may contain secrets that shouldn't be publicly available. Since we're using local APIs to build the site, this shouldn't have any impact on generating pages.

Type of change

  • Chore

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

kilemensi added 6 commits May 29, 2025 09:19
@kilemensi
Add environment to site
d5eb4ff 
 + We use SENTRY_ENVIRONMENT to detect whether we're running local,
   dev/staging or production
 + Remove vercel code as we no longer deploy there
 + remove unused logoUrl since we now have proper CMS
@kilemensi
Use site.url
aa38fcc
@kilemensi
Use site.environment to set hideAPIURL
da4f1ab
@kilemensi
Configure hideAPIURL in collections + enable autosave in Pages
f671b63
@kilemensi
Configure hideAPIURL in globals + improve localized in group fields
bc80bc2 
Also ensure only looggeIn users can read settings as it may contain
secrets. Since we're using local APIs, this shouldn't impact building
the site.
@kilemensi
Merge branch 'main' into chore/trustlab_improve_payload
33424b6
@kilemensi kilemensi requested a review from a team May 29, 2025 06:33
@kilemensi kilemensi self-assigned this May 29, 2025
@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label May 29, 2025
@github-project-automation github-project-automation bot moved this to 🚧 In Progress in COMMONS May 29, 2025
@kilemensi
Copy link
Member Author

kilemensi commented May 29, 2025

FYI @CodeForAfrica/tech, the linting issues are project-level issues and not related to the changes in this PR. They're fixed as part of this PR. May be we should start by reviewing and merging that one.

@kilemensi kilemensi added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit bd34bfd May 29, 2025
5 checks passed
@kilemensi kilemensi deleted the chore/trustlab_improve_payload branch May 29, 2025 10:55
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✅ Done in COMMONS May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koechkevin koechkevin koechkevin approved these changes

Assignees

@kilemensi kilemensi

Labels

chore A task that needs to be done (neither enhancement or bug)

Projects

COMMONS
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kilemensi @koechkevin