-
-
Notifications
You must be signed in to change notification settings - Fork 15
fix: deploy API and CI for sandbox + live #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TineoC
wants to merge
12
commits into
CodeForPhilly:develop
Choose a base branch
from
TineoC:fix/deploy-api-and-ci
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add trailing newline to frontend/.env.production (lint) - Clarify apiClient baseURL comment for sandbox/production - Add Frontend: Lint and Build workflow on develop - Add docs/DEPLOY_RESOLUTION_STEPS.md for PR follow-up
- devbox.json: use kind-config.yaml (file exists as .yaml) - deploy/manifests/balancer/overlays/kind: overlay with secretGenerator for balancer-config (SQLite) so kind runs without PostgreSQL - deploy/kind-test.sh: create cluster, install ingress, build/load image, apply kind overlay, wait for deployment, curl API and verify status
…ath" This reverts commit 1b36e6f.
…, manual deploy - Deploy: Downstream: add permissions (contents, actions, pull-requests), add workflow_dispatch target (both|sandbox|live) for manual deploy; CD to sandbox on develop, live on release; manual run opens PRs to cluster repos - Remove frontend/.env.production and VITE_API_BASE_URL from .env (relative URLs) - SPA catch-all: always register, serve index.html at request time or 404 - Docs: README/CLAUDE/MIGRATION/DEPLOY_RESOLUTION_STEPS and PR body
This was referenced Feb 1, 2026
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Single PR that fixes deploy/API/CI for sandbox + live.
Included:
.env.production(not needed; frontend uses relative API URLs for sandbox/live)Frontend and environment: The frontend uses relative API URLs (
baseURL = ""), so one image works for both environments: when running on sandbox (balancer.sandbox.k8s.phl.io) it calls that host; when running on live (balancerproject.org) it calls that host. No env-specific build or config required.Not closed: #451 (sanitizer) – unrelated; left open.
GitOps CD and manual deploy:
Deploy: Downstreamnow has explicit permissions and atargetinput for workflow_dispatch (both|sandbox|live). CD: push todevelop→ Containers: Publish → deploy PR to cfp-sandbox-cluster. Live: publish release → deploy PR to cfp-live-cluster. Manual: run Deploy: Downstream with a tag (and optional target) to open deploy PRs without waiting for develop/release. Jobs were failing due to missing permissions and token; BOT_GITHUB_TOKEN must have write access to both cluster repos (see docs/DEPLOY_RESOLUTION_STEPS.md).Other: SPA catch-all always registered (serve index.html at request time or 404). Removed
.env.productionand unusedVITE_API_BASE_URLfrom frontend.env.Related
Reviewers
@chris (for deploy/secrets follow-up; see docs/DEPLOY_RESOLUTION_STEPS.md)