Fix issue with property address search not working #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weekly PR from Staging to Main
# 1.0.0 (2025-01-02) ### Bug Fixes * **572:** fix webpack warnings + fix linting issues ([CodeForPhilly#574](https://github.com/CodeWritingCow/vacant-lots-proj/issues/574)) ([fbfd459](fbfd459)) * Add focus styling to header links ([a99065c](a99065c)) * Add href to dropdown items to increase link size ([2eb4667](2eb4667)) * correct the scrolling on the map page ([a850237](a850237)) * Remove nested link and button ([d93e8bd](d93e8bd)) * Update footer markup structure for accessibility ([d5c2a33](d5c2a33)) ### Features * **247:** make the mapbox legend more legible ([bcf6915](bcf6915)) * **293:** sort features by priority of high, medium, low ([8cd1058](8cd1058)) * **305:** expand the header width of single property table ([b25261e](b25261e)) * **395:** add white background to backbutton bar ([a65f052](a65f052)) * **395:** make property selection back button sticky ([6601201](6601201)) * **457:** add filter count to button ([b35145a](b35145a)) * **535:** add close download view button ([CodeForPhilly#579](https://github.com/CodeWritingCow/vacant-lots-proj/issues/579)) ([9bd2c53](9bd2c53)) * **544:** adjust remove property section ([CodeForPhilly#580](https://github.com/CodeWritingCow/vacant-lots-proj/issues/580)) ([900af8e](900af8e)) * **568:** restyle the property table ([CodeForPhilly#577](https://github.com/CodeWritingCow/vacant-lots-proj/issues/577)) ([2c8cc92](2c8cc92)) * Add arrow icon to link ([6bce3fa](6bce3fa)) * Add content to sidebar ([23d5c52](23d5c52)) * Add council district ([e576218](e576218)) * Add extra data to single detail page ([48e34fe](48e34fe)) * Add font ([c1a8b93](c1a8b93)) * Add font to map ([1491518](1491518)) * Add font to search field ([3b08069](3b08069)) * Add info cards ([8170944](8170944)) * Add missing data and atlas link; style table ([8c260d4](8c260d4)) * Add percentage, update column widths ([41caf77](41caf77)) * Add priority color square ([ad5a9fa](ad5a9fa)) * add redirect from map to find-properties ([439ed6c](439ed6c)) * Add row scope ([f945979](f945979)) * Add spacing below Back button ([7de48c5](7de48c5)) * Address a few more links ([b3b6733](b3b6733)) * Adjust table per requirements ([36e6cfa](36e6cfa)) * Change Find Properties and Learn More to links ([1de0b47](1de0b47)) * Close sidebar if clicking on empty map ([612117d](612117d)) * Navigate to map on click; show popups ([183b6a2](183b6a2)) * Open sidebar from map ([5474367](5474367)) * Pass selected property to map view ([663f142](663f142)) * underline links ([5f23d09](5f23d09)) * Update aria label and role ([765e5a4](765e5a4))
Replace Mapbox geocoding control with Maptiler Geocoding control. Comment out line of code that was causing NextJS Web application to crash.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes bug #1057 where the property address search box stopped working. This PR migrates the search box from MapboxGeocoder to GeocodingControl.
This PR incorporates elements of PR #1003 which had been reverted due to a bug.
Screen recording
Video of looking up a property with GeocodingControl
screen.recording.ticket.1068.mov