Mobile nav dropdown accessibility #1134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s closing on escape or tab which returns focus to the hamburger upon closing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
SofiaFasullo
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses closing out some of the existing accessibility features regarding the hamburger navigation dropdown when in mobile view. The two issues listed below detail the need for navigation through the dropdown options with the arrow keys and closing it with the escape or tab key.
This was implemented in the
<MobileNav />component using a collection of refs that cycle through focus according the arrow key strokes captured by an event listener.Related Issue(s)
This PR addresses issue #979 and #980.