Skip to content

Conversation

@adamzev
Copy link
Contributor

@adamzev adamzev commented Mar 31, 2025

Pull Request Title

Checklist:

Before submitting your PR, please confirm that you have done the following:

  • I have opened my PR against the staging branch, NOT against main
  • I've run the relevant formatting and linting tools listed in the setup docs
  • I have commented hard-to-understand areas in my code
  • I've reviewed any merge conflicts to make sure they are resolved
  • My changes generate no new warnings

Description

Prevented attempts to alter tables before they exist
Prevented API calls from being appended/stored multiple times.
Fixed a subtle bug where the gdf would be replaced with the contents of the most recent API call when not intended in pwd_parcels

Related Issue(s)

This PR addresses issue #1152

Type of change

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

I have some other pending merge requests that are required in combination with this one for successful runs. I'm going to keep this a draft and then pull them all together locally to verify that everything works together.

nlebovits and others added 5 commits March 14, 2025 09:16
---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Collum <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Adam Levin <[email protected]>
Co-authored-by: Nissim Lebovits <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Collum <[email protected]>
# 1.0.0 (2025-03-25)

### Bug Fixes

* **572:** fix webpack warnings + fix linting issues ([CodeForPhilly#574](https://github.com/adamzev/clean-and-green-philly/issues/574)) ([fbfd459](fbfd459))
* Add focus styling to header links ([a99065c](a99065c))
* Add href to dropdown items to increase link size ([2eb4667](2eb4667))
* closing tooltip popup on map closes property details ([432e8c0](432e8c0))
* correct the scrolling on the map page ([a850237](a850237))
* Remove nested link and button ([d93e8bd](d93e8bd))
* Update footer markup structure for accessibility ([d5c2a33](d5c2a33))

### Features

* **247:** make the mapbox legend more legible ([bcf6915](bcf6915))
* **293:** sort features by priority of high, medium, low ([8cd1058](8cd1058))
* **305:** expand the header width of single property table ([b25261e](b25261e))
* **395:** add white background to backbutton bar ([a65f052](a65f052))
* **395:** make property selection back button sticky ([6601201](6601201))
* **457:** add filter count to button ([b35145a](b35145a))
* **535:** add close download view button ([CodeForPhilly#579](https://github.com/adamzev/clean-and-green-philly/issues/579)) ([9bd2c53](9bd2c53))
* **544:** adjust remove property section ([CodeForPhilly#580](https://github.com/adamzev/clean-and-green-philly/issues/580)) ([900af8e](900af8e))
* **568:** restyle the property table ([CodeForPhilly#577](https://github.com/adamzev/clean-and-green-philly/issues/577)) ([2c8cc92](2c8cc92))
* Add arrow icon to link ([6bce3fa](6bce3fa))
* Add content to sidebar ([23d5c52](23d5c52))
* Add council district ([e576218](e576218))
* Add extra data to single detail page ([48e34fe](48e34fe))
* Add font ([c1a8b93](c1a8b93))
* Add font to map ([1491518](1491518))
* Add font to search field ([3b08069](3b08069))
* Add info cards ([8170944](8170944))
* Add missing data and atlas link; style table ([8c260d4](8c260d4))
* Add percentage, update column widths ([41caf77](41caf77))
* Add priority color square ([ad5a9fa](ad5a9fa))
* add redirect from map to find-properties ([439ed6c](439ed6c))
* Add row scope ([f945979](f945979))
* Add spacing below Back button ([7de48c5](7de48c5))
* Address a few more links ([b3b6733](b3b6733))
* Adjust table per requirements ([36e6cfa](36e6cfa))
* Change Find Properties and Learn More to links ([1de0b47](1de0b47))
* Close sidebar if clicking on empty map ([612117d](612117d))
* Navigate to map on click; show popups ([183b6a2](183b6a2))
* Open sidebar from map ([5474367](5474367))
* Pass selected property to map view ([663f142](663f142))
* underline links ([5f23d09](5f23d09))
* Update aria label and role ([765e5a4](765e5a4))
Prevented attempts to alter tables before they exist

Prevented API calls from being appended/stored multiple times.

Fixed a subtle bug where the gdf would be replaced with the contents
of the most recent API call when not intended in pwd_parcels
@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 2:29pm

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

This PR has been marked as stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Apr 8, 2025
@adamzev adamzev closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants