-
Notifications
You must be signed in to change notification settings - Fork 91
Unit testing for some of the basic services #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing for some of the basic services #1183
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
…the pipeline code
…- commented out different diff reports and slack updates to focus on the caching and loading mechanism for now, will add them back in later
… it working for running and caching files in geoparquet form
…oss the different class methods
… loading of source files
|
This pull request seems to have a lot going on it. I see some stuff on switching from the old pipeline to the new (script to main.py), removing postgres, and adding the tests. Also some functionality is commented out such as sending data to Slack. We may want to remove that but wouldn't just want to leave it as a comment. I see this is a draft. I take it we'll separate out those changes in different merge requests? |
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
Before submitting your PR, please confirm that you have done the following:
stagingbranch, NOT againstmainDescription
This PR introduces some unit test coverage of the several of the services called in the pipeline. It focuses on the more basic ones without any needs to hit an external API, and rather those that do some extra calculations or transformations on the present dataset when they are called.
Related Issue(s)
This is a partial answer to #1178 with additional testing still needed.