Skip to content

Conversation

@cfreedman
Copy link
Contributor

Before submitting your PR, please confirm that you have done the following:

  • I have opened my PR against the staging branch, NOT against main
  • I've run the relevant formatting and linting tools listed in the setup docs
  • I have commented hard-to-understand areas in my code
  • I've reviewed any merge conflicts to make sure they are resolved
  • My changes generate no new warnings

Description

This PR introduces some unit test coverage of the several of the services called in the pipeline. It focuses on the more basic ones without any needs to hit an external API, and rather those that do some extra calculations or transformations on the present dataset when they are called.

Related Issue(s)

This is a partial answer to #1178 with additional testing still needed.

@vercel
Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 5:16pm

@github-actions
Copy link
Contributor

This PR has been marked as stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Apr 29, 2025
@github-actions github-actions bot removed the stale label Apr 30, 2025
@adamzev
Copy link
Contributor

adamzev commented May 10, 2025

This pull request seems to have a lot going on it. I see some stuff on switching from the old pipeline to the new (script to main.py), removing postgres, and adding the tests. Also some functionality is commented out such as sending data to Slack. We may want to remove that but wouldn't just want to leave it as a comment.

I see this is a draft. I take it we'll separate out those changes in different merge requests?

@cfreedman cfreedman changed the base branch from staging to pipeline-integration May 10, 2025 20:14
@github-actions
Copy link
Contributor

This PR has been marked as stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label May 18, 2025
@cfreedman cfreedman closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants