Skip to content

Conversation

@grahamalama
Copy link
Contributor

Checklist:

Before submitting your PR, please confirm that you have done the following:

  • I have opened my PR against the staging branch, NOT against main
  • I've run the relevant formatting and linting tools listed in the setup docs
  • I have commented hard-to-understand areas in my code
  • I've reviewed any merge conflicts to make sure they are resolved
  • My changes generate no new warnings

Description

This is a large PR with 55 files changed, but it's not as big as it looks!

Essentially, I've modified the structure of our Python structure so that src becomes the package that we import from. This way, we don't need to patch PYTHONPATH at all.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Internal change

How Has This Been Tested?

To test this I:

  • cded into the data directory
  • set a POSTGRES_PASSWORD and POSTGRES_PORT=5433 in an .env file
  • spun up the Postgres database
  • ran pipenv run pytest
  • observed the tests passing

@vercel
Copy link

vercel bot commented May 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2025 4:30pm

@grahamalama grahamalama changed the title Modify Python Structure so that we treat src is a package Modify Python Structure so that we treat src as a package May 18, 2025
@github-actions
Copy link
Contributor

This PR has been marked as stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label May 26, 2025
@cfreedman cfreedman self-requested a review May 29, 2025 01:15
@cfreedman cfreedman merged commit b323c68 into CodeForPhilly:staging May 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants