Conversation
Owner
|
I will test it somewhere this week, don't have a demo project ready at the moment. |
CodeWithDennis
approved these changes
Apr 4, 2025
This was referenced Apr 5, 2025
Merged
|
Please don't commit without test! :) This change had shut down our panel and empty select tree field in forms was returning filled array 🤦♂️ |
Owner
PR is already reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor prepend and getCustomKey methods.
Extend getState method from hasState trait.
The idea is to convert all
valuesfor treejs to strings.I think this is a better solution than editing the
index.js.So, no matter what the key and parent key are (integer id, string uid, string code), they will always be converted to a string, and treejs will correctly find the selected items regardless of where they come from (session, db, url query string).