Fix 131 #153
Merged
Fix 131 #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate the build artifact for filament-select-tree.js to incorporate recent changes. This ensures the latest updates are reflected in the distributed file.
Typecasting for keys and parent attributes in `SelectTree` has been streamlined, removing redundant logic and improving code clarity. Adjustments in the README and JavaScript enhance consistency in query handling and return types.
Removed redundant blank lines and refined spacing for better code readability. Adjusted conditional key assignment logic to ensure consistent formatting without altering functionality.
Removed redundant blank lines and refined spacing for better code readability. Adjusted conditional key assignment logic to ensure consistent formatting without altering functionality.
Owner
|
No worries! I will do some good testing and maybe @ariaieboy can take a look at this branch as well? |
Contributor
I will test this branch and tell you the result. |
Owner
|
Got some conflicts because we have updated the package in the lastest version - @lotestudio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry and apologies for the problem. This is definitely a Livewire bug, and I looked at how the Filament team solves it. Here is a fix and a video with expected behaviors. We don't have tests, and I might be missing something. It's your decision to merge it.
SelectTree.mp4