fix: Add support for customizable tree key in SelectTree #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a `treeKey` property and associated methods to allow customization of the tree identifier. Updated Blade template to use the specified tree key for the `wire:key` attribute to ensure predictable component rendering. This is to address issue CodeWithDennis#141.
Contributor
Author
|
well... after more testing, this still seems to not work on first render. whatever issue is causing that is still an issue. but the rerendering issue where the select box would disappear is fixed with this. |
Updated the `FilamentView::hasSpaMode` method to include the current URL as a parameter. This ensures the SPA mode condition is evaluated more precisely based on the current context.
Contributor
Author
|
Added current url in the spaMode check to allow the spaUrlExceptions to work correctly. Were not working for me until this. |
Updated the treeKey property to use a dynamic default value, ensuring more flexibility. Also adjusted the setUp method to initialize treeKey with a randomized suffix for uniqueness.
Contributor
Author
|
@CodeWithDennis - per your comment in the other PR, I think this one is 'ready' for you to take, as it took feedback from @neverything on the 'default to rand'. This defaults to a default string key with rand value appended (in setup). And this has a fix for 'spa' check to evaluate based on the current url. |
Owner
|
Thanks! @mgkimsal @neverything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
treeKeyproperty and associated methods to allow customization of the tree identifier. Updated Blade template to use the specified tree key for thewire:keyattribute to ensure predictable component rendering.This is to address issue #141