Prevent Excel export from generating two sheets#261
Merged
abzainuddin merged 1 commit intomasterfrom Mar 22, 2025
Merged
Conversation
Previously, the Excel export created a new sheet after creating the workbook, but the Workbook constructor already creates a default sheet. This caused customers to open the export and see the first, empty sheet, thinking the export was broken rather than clicking on the second sheet.
PXJesse
force-pushed
the
excel-export-remove-duplicate-sheet
branch
from
c8cd0cc to
5160de7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Excel export created a new sheet after creating the workbook, but the Workbook constructor already creates a default sheet. This caused customers to open the export and see the first, empty sheet, thinking the export was broken rather than clicking on the second sheet.