Skip to content

London11 | Karla Grajales | Module-Data-Groups | Sprint-3 Debugging Book-Library-Book #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Grajales-K wants to merge 11 commits into from
Closed

London11 | Karla Grajales | Module-Data-Groups | Sprint-3 Debugging Book-Library-Book #151

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7d232c0
missing for loop brackets on line 57, added
Grajales-K Jan 19, 2025
8836023
changed let for const to create the new button
Grajales-K Jan 19, 2025
6688f1b
bug with declaration of variable fixed with delButton
Grajales-K Jan 19, 2025
d20bada
fixed bug incorrect name event, clicks instead "click"
Grajales-K Jan 19, 2025
86d7c97
fixed boolean comparision to false == "No"
Grajales-K Jan 19, 2025
784e45d
fixed boolean comparision to false == "No"
Grajales-K Jan 19, 2025
8653109
fixed bug incorrect name event, clicks instead "click"
Grajales-K Jan 19, 2025
db8d177
Merge pull request #1 from Grajales-K/main
Grajales-K Jan 19, 2025
b5f00c7
tested ok
Grajales-K Jan 19, 2025
323fbf6
fix the user to type negative number and decimal values.
Grajales-K Jan 20, 2025
7ef843a
adapted the alert message to prevent to deleted it.
Grajales-K Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 33 additions & 12 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
Expand Down Expand Up @@ -37,8 +37,8 @@ function submit() {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
}
}
Expand All @@ -54,7 +54,7 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
Expand All @@ -77,9 +77,9 @@ function render() {
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
} else {
readStatus = "Yes";
}
changeBut.innerText = readStatus;

Expand All @@ -88,13 +88,34 @@ function render() {
render();
});

// // second option to booleans comparisons
// let changeBut = document.createElement("button");
// changeBut.id = i;
// changeBut.className = "btn btn-success";
// wasReadCell.appendChild(changeBut);
// let readStatus = "";

// // Directly check for boolean value (true or false)
// if (myLibrary[i].check == false) {
// readStatus = "No";
// } else {
// readStatus = "Yes";
// }

// changeBut.innerText = readStatus;

// changeBut.addEventListener("click", function () {
// myLibrary[i].check = !myLibrary[i].check; // Toggle the read status
// render();
// });

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
const delButton = document.createElement("button");
delButton.id = i + 5;
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down