-
-
Notifications
You must be signed in to change notification settings - Fork 162
Sheffield | May 2025 | Hassan Osman | Sprint 2 | Book Library Project | Feature/book library #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
1b8bd32
ed0ee61
f7421a4
38ba266
0b17d3f
783b2fe
c010c24
b4d3d8d
3f2fa61
e74e343
adc9355
9adf893
c01bbc9
9b511d4
3480561
d8221e1
df1d123
d14a06c
d2e13c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,31 +16,46 @@ function populateStorage() { | |
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const readCheckbox = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| titleInput.value = titleInput.value.trim().replace(/\s+/g, " "); | ||
| authorInput.value = authorInput.value.trim().replace(/\s+/g, " "); | ||
| pagesInput.value = pagesInput.value.trim(); | ||
|
|
||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| titleInput.value === "" || | ||
| authorInput.value === "" || | ||
| pagesInput.value === "" | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| } | ||
|
|
||
| if (isNaN(pagesInput.value) || pagesInput.value <= 0 || pagesInput.value > 10000) { | ||
| alert("Please enter a valid page count (1–10000)."); | ||
| return false; | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indentation is a bit off.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My bad. Corrected now. |
||
|
|
||
| let book = new Book( | ||
| titleInput.value, | ||
| authorInput.value, | ||
| parseInt(pagesInput.value, 10), | ||
| readCheckbox.checked | ||
| ); | ||
|
|
||
| myLibrary.push(book); | ||
| render(); | ||
|
|
||
|
|
||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
|
|
@@ -51,53 +66,56 @@ function Book(title, author, pages, check) { | |
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| let tbody = document.querySelector("#display tbody"); | ||
|
|
||
| //Clear all rows at once | ||
| tbody.innerHTML = ""; | ||
|
|
||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let row = tbody.insertRow(0); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
| titleCell.textContent = myLibrary[i].title; | ||
| authorCell.textContent = myLibrary[i].author; | ||
| pagesCell.textContent = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readBtn = document.createElement("button"); | ||
|
|
||
| readBtn.className = "btn btn-success"; | ||
| wasReadCell.appendChild(readBtn); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } else { | ||
| readStatus = "Yes"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| readBtn.innerText = readStatus; | ||
|
||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| readBtn.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| render(); | ||
| }); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| let deleteBtn = document.createElement("button"); | ||
|
|
||
| deleteCell.appendChild(deleteBtn); | ||
| deleteBtn.className = "btn btn-warning"; | ||
| deleteBtn.innerHTML = "Delete"; | ||
| deleteBtn.addEventListener("click", function () { | ||
| const deletedTitle = myLibrary[i].title; | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| setTimeout(() => { | ||
| alert(`You've successfully deleted the book titled: ${deletedTitle}`); | ||
| }, 250); | ||
|
|
||
| }); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not introduce variables with shorter names so that you don't have to type as much in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the variable names that long? 😅 For example, I could've changed "titleInput" to "titleInpt" or "titInput" but I didn't want to compromise on the meaningfulness of the variables. Having said that, I'll aim to produce as much shorter & meaningful variable names in the future moving forward. Thank you CJ 😁