Skip to content

West Midlands | ITP 2025 MAY | Peter Lui | Sprint 2| Book Library #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petergmlui wants to merge 4 commits into from
Closed

West Midlands | ITP 2025 MAY | Peter Lui | Sprint 2| Book Library #312

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3be304c
initial upload
petergmlui Aug 18, 2025
a796835
bug fixes
petergmlui Aug 18, 2025
76e9852
fixed input field check
petergmlui Aug 20, 2025
b56d04a
cleaned comments and added max book pages of 30,000
petergmlui Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 41 additions & 47 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,48 +27,49 @@ <h1>Library</h1>
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<div id="demo" class="collapse">
<form id="book-form">
<div class="form-group">
<label for="title">Title:</label>
<input
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author:</label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
/>
</div>
</form>
</div>

<table class="table" id="display">
<thead class="thead-dark">
Expand All @@ -81,13 +82,6 @@ <h1>Library</h1>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>

Expand Down
108 changes: 58 additions & 50 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,63 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
// console.log("Page loaded, initializing library");
populateStorage();
render();
});

// Attach form submit event listener
document.getElementById("book-form").addEventListener("submit", function (event) {
// console.log("Form submit event triggered");
event.preventDefault(); // Prevent default form submission
submit();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
const storedLibrary = localStorage.getItem("myLibrary");
if (storedLibrary) {
// console.log("Loading myLibrary from localStorage:", storedLibrary);
myLibrary = JSON.parse(storedLibrary);
} else {
// console.log("No data in localStorage, initializing with default books");
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true);
myLibrary.push(book1, book2);
localStorage.setItem("myLibrary", JSON.stringify(myLibrary));
}
render();
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
// console.log("submit() function called");
Copy link

@LonMcGregor LonMcGregor Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all this commented code is not needed, what impact does leaving it here have on the rest of the code?

Copy link
Author

@petergmlui petergmlui Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment doesn't affect code. its only for my own reading.

// console.log("Input values:", {
// title: title.value,
// author: author.value,
// pages: pages.value,
// read: check.checked
// });

// if (!title.value.trim() || !author.value.trim() || !pages.value || isNaN(parseInt(pages.value))) {
Copy link

@LonMcGregor LonMcGregor Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have commented out the validation here - the form does some of it for you which is fine. But can you think of any edge cases where the "required" validation might not be enough?

Copy link
Author

@petergmlui petergmlui Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is good advise. it was commented out during testing. i have put the check back in. thank you!

// console.log("Validation failed: One or more fields are empty or invalid");
// alert("Please fill all fields with valid data!");
// return;
// }

let book = new Book(title.value.trim(), author.value.trim(), parseInt(pages.value), check.checked);
// console.log("New book created:", book);
myLibrary.push(book);
// console.log("myLibrary after push:", myLibrary);
localStorage.setItem("myLibrary", JSON.stringify(myLibrary));
render();
document.querySelector("form").reset();
// console.log("Form reset");
$("#demo").collapse("hide");
// console.log("Form collapsed");
}

function Book(title, author, pages, check) {
Expand All @@ -51,16 +68,14 @@ function Book(title, author, pages, check) {
}

function render() {
// console.log("render() called, myLibrary:", myLibrary);
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
for (let i = 0; i < myLibrary.length; i++) {
let row = table.insertRow(-1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
Expand All @@ -70,34 +85,27 @@ function render() {
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.id = `read-${i}`;
changeBut.className = "btn btn-success";
changeBut.innerText = myLibrary[i].check ? "Yes" : "No";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
localStorage.setItem("myLibrary", JSON.stringify(myLibrary));
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delButton.id = `delete-${i}`;
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
deleteCell.appendChild(delButton);
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
Copy link

@LonMcGregor LonMcGregor Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about what normally happens when you delete a file on a computer. Is the behaviour here what you might expect? Can you think of any way to improve it?

Copy link
Author

@petergmlui petergmlui Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no requirement to implement an un-delete system. my code meets the requirement.

myLibrary.splice(i, 1);
localStorage.setItem("myLibrary", JSON.stringify(myLibrary));
render();
});
}
}
}
Loading