generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 162
West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Book library #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e2bf444
Fix syntax error in for-loop (line 57) that blocked book list from re…
Iswanna c39e375
Fix: rename delButton to delBut and correct event to 'click' to enabl…
Iswanna c794174
Rename library to myLibrary in submit() so new books are added to the…
Iswanna 436136b
fix: use author.value for author field when creating a new Book (line…
Iswanna dccb8a5
fix(render): correct read status display so checked=true shows “Yes” …
Iswanna 07c6620
Remove redundant render() call in populateStorage (line 19) to avoid …
Iswanna 085a373
Remove placeholder table row <tr> from <tbody> to allow render() to m…
Iswanna 4bf7b31
Fix invalid HTML input types by changing <input type="title"/> and <i…
Iswanna d9870cf
Switch script.js to type="module", remove inline onclick="submit()", …
Iswanna 3acd315
Add id="submitBtn" to the submit button to enable attaching an event …
Iswanna dae6c85
Refactor code to remove redundant null checks on input values, ensure…
Iswanna a6619ba
Refactor variable names for clarity: DOM inputs now use descriptive n…
Iswanna d413566
fix(js): add full input validation for author and page count
Iswanna c784153
refactor(js): optimize table clearing using tbody.innerHTML
Iswanna 4757d2f
Clear rows via tbody.innerHTML to preserve header and speed up re-render
Iswanna 0a4c4ae
ux(delete): confirm before deletion and show non-blocking success alert
Iswanna 757fcd3
Correct book title spelling from “Robison Crusoe” to “Robinson Crusoe…
Iswanna 2b98534
Fix(form): prevent default submit to avoid page reload on Submit butt…
Iswanna 63652a8
Chore(html): add lang, split meta tags, set meaningful title, and mak…
Iswanna 7c28cc2
Add #alerts container and move the dependency scripts to end of the body
Iswanna 9526485
Fix indentation inconsistency in index.html
Iswanna 9c3c39f
refactor(notices): use #alerts container with CSS-only auto-hide; rem…
Iswanna 2417ca4
fix(validation): require pages to be a positive integer
Iswanna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking
!Number.isInteger(pages) || pages < 1would be enough.