Skip to content

Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 2 | Book Library #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakr-s wants to merge 16 commits into from
Closed

Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 2 | Book Library #351

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
542c0c1
fix: correct typo in delete button logic
jakr-s Dec 11, 2025
bb7e874
fix: update condition for read status
jakr-s Dec 11, 2025
556cd3e
fix: correct syntax error in render function loop
jakr-s Dec 11, 2025
43b06b0
fix: correct book object creation in submit function
jakr-s Dec 11, 2025
13abce6
fix: use strict equality in populateStorage function
jakr-s Dec 11, 2025
606b90f
fix: correct input types and formatting in index.html
jakr-s Dec 11, 2025
d0ce382
fix: update HTML structure using w3 validator
jakr-s Dec 12, 2025
2457257
fix: load script as an ES module
jakr-s Dec 12, 2025
7dc7f7a
fix: remove unnecessary render call in populateStorage function
jakr-s Dec 12, 2025
e127057
fix: standardize variable names for book properties
jakr-s Dec 12, 2025
3a51927
fix: correct variable name for table element in render function
jakr-s Dec 12, 2025
0d05722
fix: refactor Book constructor to use class syntax
jakr-s Dec 18, 2025
2a6ec9f
fix: improve input validation and refactor book creation
jakr-s Dec 18, 2025
eecd7da
fix: correct data type for pages
jakr-s Dec 18, 2025
2e28e34
fix: expose submit function to global scope
jakr-s Dec 18, 2025
77aca39
fix: refactor render function
jakr-s Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title> </title>
<title>Book Library</title>
<meta
charset="utf-8"
name="viewport"
Expand Down Expand Up @@ -31,15 +31,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -65,7 +65,7 @@ <h1>Library</h1>
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
onclick="submit()"
/>
</div>
</div>
Expand Down
27 changes: 11 additions & 16 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ window.addEventListener("load", function (e) {
});

function populateStorage() {
if (myLibrary.length == 0) {
if (myLibrary.length === 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
Expand All @@ -28,17 +28,12 @@ const check = document.getElementById("check");
//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
if (!title.value || !author.value || pages.value <= 0) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
}
}
Expand All @@ -54,7 +49,7 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
Expand All @@ -76,7 +71,7 @@ function render() {
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check === true) {
readStatus = "Yes";
} else {
readStatus = "No";
Expand All @@ -90,11 +85,11 @@ function render() {

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delButton.id = i + 5;
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down
Loading