Skip to content

Manchester| 25-ITP-SEP| Fithi Teklom| Sprint 2 | Book Library #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fithi-Teklom wants to merge 11 commits into from
Closed

Manchester| 25-ITP-SEP| Fithi Teklom| Sprint 2 | Book Library #361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5101361
debugged the issue on the javascript file and modified html file.
Fithi-Teklom Dec 16, 2025
8be6584
formatted it in the first place
Fithi-Teklom Dec 18, 2025
69ea84e
removed unnecessary slashes
Fithi-Teklom Dec 18, 2025
c719ec1
some adjustments
Fithi-Teklom Dec 18, 2025
b8cfc20
used html validator and there is no error
Fithi-Teklom Dec 18, 2025
333f269
made some modifications in the js file
Fithi-Teklom Dec 18, 2025
db2bff7
wrote a conditional statement in a single statement
Fithi-Teklom Dec 19, 2025
536e55a
assign the DOM via textContent
Fithi-Teklom Dec 19, 2025
cfe2650
removed unnecessary variables
Fithi-Teklom Dec 19, 2025
bee984d
made some changes
Fithi-Teklom Dec 19, 2025
ff8a6ea
fixed the bug
Fithi-Teklom Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ <h1>Library</h1>
/>Read
</label>
<input
type="submit"
type="button"
value="Submit"
class="btn btn-primary"
onclick="submit();"
onclick="addButton();"
/>
</div>
</div>
Expand Down
16 changes: 9 additions & 7 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,20 @@ const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
function addBook() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
pages.value == "" ||
author.value == null ||
author.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
myLibrary.push(book);
render();
}
}
Expand All @@ -54,7 +56,7 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n-- ) {
table.deleteRow(n);
}
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider using a more efficient approach to clear the table.

//insert updated row and cells
Expand All @@ -76,7 +78,7 @@ function render() {
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check == true) {
readStatus = "Yes";
} else {
readStatus = "No";
Expand All @@ -89,12 +91,12 @@ function render() {
});

//add delete button to every row and render again
let delButton = document.createElement("button");
let delBut = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delBut.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down
Loading