Skip to content

London | 25-ITP-Sep |Mariia Serhiienko | Sprint 2 | Book Library Project #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Konvaly wants to merge 10 commits into from
Closed

London | 25-ITP-Sep |Mariia Serhiienko | Sprint 2 | Book Library Project #368

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4136ae2
Fix syntax error in render loop preventing initial render
Konvaly Dec 16, 2025
478a62d
Fix delete button variable name causing render crash
Konvaly Dec 16, 2025
4843708
Fix author field when creating new Book from form input
Konvaly Dec 16, 2025
ab5513e
Fix read status logic when rendering books
Konvaly Dec 16, 2025
1fb8577
Fix delete button by using correct click event listener
Konvaly Dec 16, 2025
610f0ce
Clear form fields after successful book submission
Konvaly Dec 16, 2025
6acbd7c
Prevent adding duplicate books by title
Konvaly Dec 16, 2025
7168d78
Improve book form validation and render rows in tbody
Konvaly Dec 18, 2025
83183be
Fixed index.html according to validator
Konvaly Dec 18, 2025
b2536c5
Refactor according to mentor's review
Konvaly Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 49 additions & 89 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,56 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<html lang="en">

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<head>
<title>Book Library</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input type="text" class="form-control" id="title" name="title" required>
<label for="author">Author: </label>
<input type="text" class="form-control" id="author" name="author" required>
<label for="pages">Pages:</label>
<input type="number" class="form-control" id="pages" name="pages" required>
<label class="form-check-label">
<input type="checkbox" class="form-check-input" id="check" value="">Read
</label>
<input type="submit" value="Submit" class="btn btn-primary" onclick="submit();">
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody id="bookRows"></tbody>
</table>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<script src="script.js"></script>
</body>

<script src="script.js"></script>
</body>
</html>
</html>
118 changes: 62 additions & 56 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

Expand All @@ -25,22 +24,38 @@ const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const titleValue = title.value.trim();
const authorValue = author.value.trim();
const pagesValue = pages.value.trim();
const pagesNumber = Number(pagesValue);
Copy link

@jennethydyrova jennethydyrova Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add "value" to every variable because they usually hold values. Also, L30 and 31 can be merged.


if (!titleValue || !authorValue || !pagesValue) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

if (!Number.isFinite(pagesNumber) || pagesNumber <= 0) {
alert("Pages must be a positive number.");
return;
}

const alreadyExists = myLibrary.some(
(book) => book.title.toLowerCase() === titleValue.toLowerCase()
);
if (alreadyExists) {
alert("This book is already in your library!");
return;
}

let book = new Book(titleValue, authorValue, pagesNumber, check.checked);
Copy link

@jennethydyrova jennethydyrova Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it declared with let?

myLibrary.push(book);
render();

title.value = "";
author.value = "";
pages.value = "";
check.checked = false;
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +66,44 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const tbody = document.getElementById("bookRows");
tbody.textContent = "";

for (let i = 0; i < myLibrary.length; i++) {
const book = myLibrary[i];

const row = tbody.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

const changeBut = document.createElement("button");
Copy link

@jennethydyrova jennethydyrova Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing you need to change but better name would be changeBtn, this is just a convention

Copy link
Author

@Konvaly Konvaly Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed changeBut to changeBtn and delBut to delBtn

changeBut.className = "btn btn-success";
changeBut.textContent = book.check ? "Yes" : "No";
changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
book.check = !book.check;
render();
});
wasReadCell.appendChild(changeBut);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
let delBut = document.createElement("button");
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
delBut.textContent = "Delete";
delBut.addEventListener("click", function () {
const bookIndex = myLibrary.indexOf(book);
if (bookIndex === -1) return;

myLibrary.splice(bookIndex, 1);
render();
alert(`You've deleted title: ${book.title}`);
});
deleteCell.appendChild(delBut);
}
}
Loading