London | 25-ITP-May |Surafel Abdissa | Sprint 3 | Todo list #730
+149
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuWebOnes
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Aug 11, 2025
There was a problem hiding this comment.
Hi, looking at your slideshow things seem to be off to a good start.
Some feedback:
- Forward and backward functionality is working well
- The images are all different sizes so they make the buttons jump about. Can you think of any CSS styling you could add that might make the slideshow app more usable?
- Your code references auto-forward buttons, but I don't see these on the page. Can you check you committed everything?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.