Skip to content

Sheffield | ITP-May-2025 | Waleed-Yahya Salih-Taha | Sprint-3 | Quote-generator #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sheffield | ITP-May-2025 | Waleed-Yahya Salih-Taha | Sprint-3 | Quote-generator #731

wants to merge 6 commits into from

Conversation

Bluejay600
Copy link

@Bluejay600 Bluejay600 commented Jul 31, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

This PRs finds the basic setup of a quote generator, When the page loads it should show a random quote from the quotes array on the screen. It should also show who said the quote.

Questions

Ask any questions you have for your reviewer.

@Bluejay600 Bluejay600 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 31, 2025
@day-lee day-lee added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 31, 2025
day-lee
day-lee reviewed Jul 31, 2025
View reviewed changes
Sprint-3/quote-generator/index.html Outdated
<title>Quote Generator App</title>

<!-- Optional: Link to CSS if styling is needed -->
<link rel="stylesheet" href="styles.css" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you added styles to your app but it doesn't show on the page. Can you figure out why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to find out why the style code is not active on the website, but since adding style is not mandatory I thought uploading the PR will fastened my code reviewing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't working because you added an 's' to the href. href="styles.css" should match the filename in your commit, which is '../style.css'. It happens 😂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh my God. it's really my bad.
thank you for your help.

day-lee
day-lee reviewed Jul 31, 2025
View reviewed changes
Sprint-3/quote-generator/index.html Outdated
<p id="author"></p>
</section>

<button type="button" id="new-quote" aria-label="Get a new quote">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you considered accessibility and added aira-label. But when there is a visible text in the button, New quote, it might be unnecessary to add more description as screen reader might say it two times.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I will remove it then.

@day-lee
Copy link

day-lee commented Jul 31, 2025

Superb! Code looks good. I left a few comments. Please have a look.

@day-lee day-lee added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 31, 2025
@Bluejay600 Bluejay600 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 2, 2025
@Bluejay600 Bluejay600 requested a review from day-lee August 3, 2025 23:37
@day-lee day-lee added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 4, 2025
@day-lee
Copy link

day-lee commented Aug 4, 2025

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@day-lee day-lee Awaiting requested review from day-lee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bluejay600 @day-lee