London | 25-ITP-May | Fatma_Degirmenci| Sprint 3 | Quote-Generator #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatmaevin
added
the
Needs Review
day-lee
reviewed
Aug 5, 2025
| @@ -3,13 +3,19 @@ | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <title>Title here</title> | |||
| <title>Quote generator app</title> | |||
| <script defer src="quotes.js"></script> | |||
There was a problem hiding this comment.
Can you tell me what defer attribute does in script tag?
There was a problem hiding this comment.
- I used defer to make sure the script can access all the HTML elements without causing any errors.
- defer makes the browser load the HTML first, and then run the script afterwards.
day-lee
reviewed
Aug 5, 2025
There was a problem hiding this comment.
I like that you added a background photo to look nicer!
day-lee
reviewed
Aug 5, 2025
Sprint-3/quote-generator/style.css
Outdated
|
|
||
| .container { | ||
| width: 600px; | ||
|
|
|
Hi, Fatma. It works as intended and looks good! Well done. I left a few comments. Please have a look :) |
day-lee
added
Reviewed
day-lee
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Added a function to display a random quote on page load and on button click.
Added CSS to style the quote and author text.
Updated the HTML title.