Skip to content

London| ITP-May-25 | Anuar Duisenbek | Module-Data-Groups | Sprint-3 | Quote Generator App #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

London| ITP-May-25 | Anuar Duisenbek | Module-Data-Groups | Sprint-3 | Quote Generator App #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f44a50f
changed title
AnuarBey Jul 30, 2025
babfe21
feat: add quote generator functionality
AnuarBey Aug 1, 2025
a1e518d
Add CSS improvements and code comments for better clarity
AnuarBey Aug 1, 2025
45bba4c
package json instaled
AnuarBey Aug 1, 2025
e1003f6
updated npm jest and jest-dom
AnuarBey Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<link rel="stylesheet" href="style.css" />
<script defer src="quotes.js"></script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what defer attribute does in script tag?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will prevent the DOMContentLoaded event from firing until the script has loaded and finished evaluating

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, defer attribute will ensure script is downloaded in parallel but not executed until HTML document is fully parsed.

</head>
<body>
<h1>hello there</h1>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
<h1>Quote generator app</h1>
<div class="quote-box">
<div class="quote-container">
<p id="quote"></p>
<p id="author"></p>
</div>
<button type="button" id="new-quote">New quote</button>
</div>
</body>
</html>
Loading