ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 3 | Slideshow #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dave-Vermeulen
added
the
Needs Review
hkavalikas
added
Review in progress
hkavalikas
suggested changes
Aug 9, 2025
| <button id="auto-backward">Auto Backward</button> | ||
| <button id="stop">Stop Auto</button> | ||
| <label for="delayInput">Delay (seconds):</label> | ||
| <input type="number" id="delayInput" min="0.1" step="0.1" value="2" /> |
There was a problem hiding this comment.
Solid approach, but are we using this input anywhere?
How can we ensure that the delay takes the value passed here into consideration for auto-forward and backwards?
| const autoForwardBtn = document.getElementById("auto-forward"); | ||
| const autoBackwardBtn = document.getElementById("auto-backward"); | ||
| const stopBtn = document.getElementById("stop"); | ||
|
|
||
| const images = [ |
There was a problem hiding this comment.
Good use of local resources, but the requirements mention "a list of at least 4 images", and we only have 3 here.
Bonus points and completely optional: Can you find a way to replace static local images with linked ones from a site like upsplash?
hkavalikas
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
changed the slideshow and got the carousel working and the index.html files for this build. works well and pasts all tests.
Questions
Please review my code and let me know if any changes are required.