London | ITP-May-25 | Houssam Lahlah | Sprint 3 | Reading List #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed console.log to use address.houseNumber instead of address[0] - Ensures correct display of house number in output
- Replaced invalid for...of loop on object with Object.values() - Ensures all property values of author are logged without errors
- Replaced object string output with ingredients joined by newline - Ensures each ingredient is printed on its own line as intended
…and fix it from the original main branch
HoussamLh
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Aug 11, 2025
There was a problem hiding this comment.
Good work on this sprint, your reading list work well.
For your questions:
- Yes, I think this is very readable and should be easy to maintain
- One change you might want to make that could follow best practice more would be to give each element a class, and then style that class in a css file, rather than setting the colour directly in javascript. Do you want to attempt this?
- Yes, this javascript looks efficient and clear
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
## Changelist
What I did:
Implemented a reading list that dynamically displays a list of books using JavaScript.
Displayed book title and author, and added book cover images.
Highlighted books that are already read by changing their background color.
Structured the page using semantic HTML (ul, li, p, img).
Followed best practices for DOM manipulation and accessibility.
## Questions
Do you think the logic for marking books as read is clear and maintainable?
Is there anything I could improve in how I structure the list items or apply styles?
Is my use of JavaScript efficient and clear?