ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 2 | Module-Data-Groups #755
Conversation
Dave-Vermeulen
added
the
Needs Review
cjyuan
added
the
Review in progress
| if(obj === null || obj === undefined){ | ||
| return false | ||
| } | ||
| return obj[property] !== undefined; | ||
| } | ||
|
|
||
| module.exports = contains; | ||
| // work done. |
There was a problem hiding this comment.
What do you expect the from the following function calls?
contains("ABC", "1");
contains(["A", "B", "C"], "1");
contains(123, "1");
contains(true, "1");
contains({ key: undefined }, "key");Suggestion:, Look up JS "in" operator vs Object.hasOwn.
| const key = parts[0]; | ||
| const value = parts.length > 1 ? parts.slice(1).join('=') : ''; //clunky but it works to split them and stitch it together again | ||
| queryParams[key] = value; |
There was a problem hiding this comment.
Please note that in real querystring, both key and value are percent-encoded or URL encoded in the URL. For example, the string "5%" will be encoded as "5%25". So to get the actual value of "5%25" (whether it is a key or value in the querystring), you should call a function to decode it.
May I suggest looking up any of these terms, and "How to decode URL encoded string in JS"?
| function tally(items) { | ||
| if (!Array.isArray(items)){ | ||
| throw new TypeError('that aint no array bay bay'); //okay so this is the biggie smalls and its working | ||
| } | ||
| const counts = {}; | ||
|
|
||
| for (const item of items){ | ||
| counts[item] = (counts[item] || 0) +1; //simple sexy core logic | ||
| } | ||
| return counts; | ||
| } |
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion: Look up an approach to create an empty object with no inherited properties.
| @@ -10,20 +10,30 @@ function invert(obj) { | |||
| const invertedObj = {}; | |||
|
|
|||
| for (const [key, value] of Object.entries(obj)) { | |||
| invertedObj.key = value; | |||
| const numKey = Number(key); | |||
There was a problem hiding this comment.
We don't have to convert the key to a number when it looks like a number.
| // {'1':'a'} | ||
| // b) What is the current return value when invert is called with { a: 1, b: 2 } | ||
| // { '1': 'a', '2': 'b'} |
There was a problem hiding this comment.
These are the expected return value from the original code, not the actual return value.
| // d) Explain why the current return value is different from the target output | ||
|
|
||
| // cause its converted to strings, the key must be a int and the value must be a string. |
There was a problem hiding this comment.
The question is asking, why with the original code, invert({a: 1}) does not return {'1': a} (or {1:a}).
Note: The property name (key) is always a string. Even when we express the key as a number (e.g., { 1 : 'a' }), the key will still be converted to a string '1'.
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
completed the tasks within:
Questions
Please review my PR 🙏🏽