Skip to content

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Clean Quote-Generator #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+40 −8
Open

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Clean Quote-Generator #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b06cb19
Add mean calculation test
HoussamLh Jul 25, 2025
c9fbbff
Add test for calculateMedian and calculateMean using salaries array
HoussamLh Jul 25, 2025
95f7fd3
Add calculateMedian function with tests for even and odd length arrays
HoussamLh Jul 25, 2025
f02e624
I've done the prep of this sprint 2
HoussamLh Jul 30, 2025
c87010e
access houseNumber property correctly instead of using index
HoussamLh Jul 30, 2025
0b3bd51
iterate over object values correctly to log all properties
HoussamLh Jul 30, 2025
5c03c87
correctly log recipe ingredients on separate lines
HoussamLh Jul 30, 2025
89b9b6a
I just make my changes by accident in the main branch so I went back …
HoussamLh Jul 31, 2025
160cacd
Merge branch 'CodeYourFuture:main' into main
HoussamLh Aug 6, 2025
3a914e9
Add Quote Generator implementation only
HoussamLh Aug 10, 2025
8f834d7
Add Quote Generator implementation only
HoussamLh Aug 10, 2025
a3ee89b
call pickFromArray with the quotes array to check you get a random quote
HoussamLh Aug 10, 2025
36b8098
Remove prep folder from clean branch
HoussamLh Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sprint-2/debug/address.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ const address = {
postcode: "XYZ 123",
};

console.log(`My house number is ${address[0]}`);
console.log(`My house number is ${address[0]}`);
2 changes: 1 addition & 1 deletion Sprint-2/debug/recipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ const recipe = {

console.log(`${recipe.title} serves ${recipe.serves}
ingredients:
${recipe}`);
${recipe}`);
15 changes: 9 additions & 6 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<script defer src="quotes.js"></script>
<title>Random Quote Generator</title>
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>hello there</h1>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
<div class="quote-box">
<p id="quote">Loading...</p>
<p id="author"></p>
<button id="new-quote">New quote</button>
</div>

<script src="quotes.js"></script>
</body>
</html>
13 changes: 13 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,16 @@ const quotes = [
];

// call pickFromArray with the quotes array to check you get a random quote

function displayRandomQuote() {
const randomQuote = pickFromArray(quotes);
document.getElementById("quote").textContent = randomQuote.quote;
document.getElementById("author").textContent = randomQuote.author;
}

// Show a quote immediately on page load
displayRandomQuote();

// Set up button click to get a new quote
document.getElementById("new-quote").addEventListener("click", displayRandomQuote);

Comment on lines +494 to +506
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?

16 changes: 16 additions & 0 deletions Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,17 @@
/** Write your CSS in here **/
body {
font-family: Arial, sans-serif;
background: #f4f4f4;
display: flex;
justify-content: center;
align-items: center;
height: 100vh;
}

.quote-box {
background: white;
padding: 2rem;
border-radius: 1rem;
box-shadow: 0 4px 10px rgba(0, 0, 0, 0.1);
text-align: center;
}