Glasgow | 25-ITP-SEP | Hanna Mykytiuk | Sprint 1 | Coursework #817

HannaOdud · 2025-11-05T22:09:02Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Sprint 1 exercises completed.

Questions

No questions

github-actions · 2025-11-05T22:09:17Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-05T22:09:39Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-05T22:09:39Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-05T22:46:45Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-05T22:46:49Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-05T22:46:50Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-05T22:46:52Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-09T23:55:03Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module-Data-Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

The PR title and the PR description are not quite in the expected format.
Can you update them according to this PR Guide?

cjyuan · 2025-11-20T08:12:08Z

Sprint-1/fix/median.js

+  if (numbersOnly.length == 0){
+    return null;
+  }
+  const sorted =[...numbersOnly].sort((a,b) => a-b ); //we created a new arrey where we saved sorted element (as string) and turned them to numbers.


numbersOnly is no longer the original array and it is not needed later.

So we could improve the performance by not making another copy of the array and
write the code on line 16 as

const sorted = numbersOnly.sort((a, b) => a - b); // sorted and numbersOnly are the same array

Note: sorted is a more meaningful name so it is good to keep it.

cjyuan · 2025-11-20T08:14:14Z

Sprint-1/implement/dedupe.test.js

 // Then it should return a copy of the original array
-
+test("given an array with no duplicates, it should return a copy of the original array", () => {
+  const currentOutput = dedupe([5, 1, 2, 3, 8]);
+  const targetOutput = [5, 1, 2, 3, 8];
+  expect(currentOutput).toEqual(targetOutput);
+});


This test should fail if the function returns the original array (instead of a copy of the original array).

The current test checks only if both the original array and the returned array contain identical elements.
In order to validate the returned array is a different array, we need an additional check.

Can you find out what this additional check is?

cjyuan · 2025-11-20T08:18:46Z

Sprint-1/implement/max.test.js

+test("given an array with non-number values, it should return the max and ignore non-numeric values", () => {
+  const currentOutput = findMax(["a", "!", 3, 5, "0"]);
+  const targetOutput = 5;
+  expect(currentOutput).toEqual(targetOutput);
+});


Does the following function call returned the value you expect?

findMax(["1000", 1]); findMax([1000, "1"]);

cjyuan · 2025-11-20T08:21:20Z

Sprint-1/implement/max.test.js

+test("given an array with only non-number values, it should return the least surprising value given how it behaves for all other inputs", () => {
+  const currentOutput = findMax(["2", "3", "$", "%"]);
+  const targetOutput = "3";
+  expect(currentOutput).toEqual(targetOutput);
+});


Why is "3" considered the least surprising value? What's your rationale?

cjyuan · 2025-11-20T08:24:29Z

Sprint-1/implement/sum.test.js

+test("given an array with decimal/float numbers, it should return the correct total sum", () => {
+  const currentOutput = sum ([2.5, 3.1, 4.9]);
+  const targetOutput = 10.5;
+  expect(currentOutput).toEqual(targetOutput);
+});


Decimal numbers in most programming languages (including JS) are internally represented in "floating point number" format. Floating point arithmetic is not exact. For example, the result of 46.5678 - 46 === 0.5678 is false because 46.5678 - 46 only yield a value that is very close to 0.5678. Even changing the order in which the program add/subtract numbers can yield different values.

So the following could happen

expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.805 ); // This fail expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.8049999999999997 ); // This pass expect( 0.005 + 0.6 + 1.2 ).toEqual( 1.8049999999999997 ); // This fail console.log(1.2 + 0.6 + 0.005 == 1.805); // false console.log(1.2 + 0.6 + 0.005 == 0.005 + 0.6 + 1.2); // false

Can you find a more appropriate way to test a value (that involves decimal number calculations) for equality?

Suggestion: Look up

Checking equality in floating point arithmetic in JavaScript

Checking equality in floating point arithmetic with Jest

cjyuan · 2025-11-20T08:30:31Z

Sprint-1/implement/sum.js

+    if (elements.length == 0){ // check if array is empty
+        return 0;
+    }
+     if (elements.length === 1){ //check if array has one element
+        return elements[0];
+    }
+    let sum = 0;
+    let isNumbersPresent = elements.some(item => typeof item === 'number' && !isNaN(item));
+    for (let i =0; i<elements.length; i++){ //sum of elements
+        if (typeof elements[i] === 'number'){ //check if element is number
+            sum += elements[i];
+        }
+        if (isNumbersPresent == false && !isNaN(elements[i])){ //1) check if array doesnt have numbers; 2)check if element can be conversted to number
+            sum += parseFloat(elements[i]); // add converted to num element
+        }
+    }
+    return sum


Does the following function calls return the value you expected?

sum([NaN, 1]); sum(["A"]); sum(["10", 1]); sum(["10", "1"]);

github-actions · 2025-11-20T08:33:13Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module-Data-Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-20T08:33:13Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module-Data-Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-12-08T17:31:15Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sprint-1

e969dec

HannaOdud added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025

cjyuan reviewed Nov 20, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025

illicitonion closed this Jan 7, 2026

Uh oh!

Glasgow | 25-ITP-SEP | Hanna Mykytiuk | Sprint 1 | Coursework #817

Glasgow | 25-ITP-SEP | Hanna Mykytiuk | Sprint 1 | Coursework #817

Uh oh!

Conversation

HannaOdud commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HannaOdud commented Nov 5, 2025 •

edited

Loading