West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Reading List #883
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
MohammedNaru
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
MohammedNaru
added
Needs Review
| // Image first | ||
| const img = document.createElement("img"); | ||
| img.src = book.bookCoverImage; | ||
| img.alt = `${book.title} by ${book.author} — book cover`; | ||
| img.loading = "lazy"; | ||
| li.appendChild(img); | ||
|
|
||
| // Text | ||
| const p = document.createElement("p"); | ||
| p.innerText = `${book.title} by ${book.author}`; | ||
| li.appendChild(p); | ||
|
|
||
| // Inline background color (Jest reads this) | ||
| li.style.backgroundColor = book.alreadyRead ? "red" : "green"; | ||
|
|
||
| unorderedList.appendChild(li); |
There was a problem hiding this comment.
Hi, this is exactly how you would accomplish this however, this doesn't match the example given in the Readme.md where book title comes first and then the image.
| li.appendChild(p); | ||
|
|
||
| // Inline background color (Jest reads this) | ||
| li.style.backgroundColor = book.alreadyRead ? "red" : "green"; |
There was a problem hiding this comment.
This looks like the reverse logic as to the example shown in the Readme file in the task.
bp7968h
added
Reviewed
3 participants
Reading List Pull Request
Self checklist
Changelist
Completed changes to HTML file and JS file with all requirements met
Questions
No questions for the reviewer.