generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 212
London|ITP-September-2025|Mariia Serhiienko|Sprint 1|Implement #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
123b714
Added solutions into the function for 15 test cases
Konvaly 9bd3912
Added solutions for not modifying the input array
Konvaly 6e23d98
Added solutions for the arrays when length is even
Konvaly 1026829
Added solutions for the arrays with non-numeric elements
Konvaly 550590f
Changed name for filteredArr to filteredNumericArr to make it more me…
Konvaly 2cc519c
Added tests and implemented solution for the implement section - max.…
Konvaly 0799426
Added tests and implemented solution for the implement section - sum.…
Konvaly 821e75a
Added tests and implemented solution for the implement section - dedu…
Konvaly 5edb209
Added tests and implemented solution for the refactor section - inclu…
Konvaly 9df7c23
Fixed median.js
Konvaly e027a30
Fixed sum.js
Konvaly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,15 @@ | ||
| function dedupe() {} | ||
| function dedupe(arr) { | ||
| if (arr.length === 0) return []; | ||
|
|
||
| const noDupsArr = []; | ||
| const seenItems = new Set(); | ||
|
|
||
| for (const el of arr) { | ||
| if (!seenItems.has(el)) { | ||
| noDupsArr.push(el); | ||
| seenItems.add(el); | ||
| } | ||
| } | ||
| return noDupsArr; | ||
| } | ||
| module.exports = dedupe; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,16 @@ | ||
| function findMax(elements) { | ||
| if (elements.length === 0) { | ||
| return -Infinity; | ||
| } else if (elements.length === 1 && typeof elements[0] === "number") { | ||
| return elements[0]; | ||
| } | ||
| const maxEl = Math.max( | ||
| ...elements.filter((el) => typeof el === "number" && !isNaN(el)) | ||
| ); | ||
|
|
||
| if (elements.length > 1) { | ||
| return maxEl; | ||
| } | ||
| } | ||
|
|
||
| module.exports = findMax; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,15 @@ | ||
| function sum(elements) { | ||
| const numbers = elements.filter( | ||
| (item) => typeof item === "number" && !isNaN(item) | ||
| ); | ||
|
|
||
| if (numbers.length === 0) return 0; | ||
|
|
||
| const total = numbers.reduce((acc, el) => acc + el, 0); | ||
|
|
||
| const decMultiplier = 100; | ||
|
|
||
| return Math.round(total * decMultiplier) / decMultiplier; | ||
| } | ||
|
|
||
| module.exports = sum; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this last logic from 24 to 28 lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because when the list has an even number of numbers, there isn’t just one middle value, but there are two. In that situation, the median is defined as the average of those two middle numbers.